New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CSSO options #167

Merged
merged 2 commits into from Mar 23, 2018

Conversation

Projects
None yet
4 participants
@usebaz
Contributor

usebaz commented Mar 20, 2018

Hi,
In some cases need change default CSSO options. Example for delete comments from minimal css.

@usebaz

This comment has been minimized.

Contributor

usebaz commented Mar 20, 2018

I test locally. Tests failing in your master.

@stereobooster

This comment has been minimized.

Collaborator

stereobooster commented Mar 20, 2018

I just merged branch, which should fix tests. You can rebase

@peterbe

This comment has been minimized.

Owner

peterbe commented Mar 21, 2018

Hi @usebaz I don't even know how this happens but this diff looks like it's changing things that were already changed in master.
I like the new feature though! It's going to need to work on the command line too for this to be ready to merge.

@usebaz

This comment has been minimized.

Contributor

usebaz commented Mar 21, 2018

@peterbe

This comment has been minimized.

Owner

peterbe commented Mar 22, 2018

Can you try to rebase this against the latest master?

witem added some commits Mar 20, 2018

master | fix TypeScript notation
Signed-off-by: a.kuzmenko <witem.artem@gmail.com>
@usebaz

This comment has been minimized.

Contributor

usebaz commented Mar 23, 2018

@peterbe I try and it seems to be correct =)

@peterbe peterbe merged commit 7e38b98 into peterbe:master Mar 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@peterbe

This comment has been minimized.

Owner

peterbe commented Mar 23, 2018

Since it's a new feature I made a new release. Since it's not breaking anything I made it a patch release: https://github.com/peterbe/minimalcss/releases/tag/v0.7.5

THANK YOU @usebaz for helping out! Please come back and hang out and help out some more.

@usebaz

This comment has been minimized.

Contributor

usebaz commented Mar 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment