From 526bebcfd2b5701b18d3e8fdccf37e8e7d6d6a1a Mon Sep 17 00:00:00 2001 From: Peter Goldstein Date: Mon, 28 Aug 2023 14:28:25 -0400 Subject: [PATCH] Upgrade webmock dependency and address lints --- Gemfile | 2 +- spec/asimov/api_v1/api_error_translator_spec.rb | 3 +-- spec/shared_examples/api_v1/httparty_client.rb | 3 +-- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/Gemfile b/Gemfile index 092b715..f8fb297 100644 --- a/Gemfile +++ b/Gemfile @@ -12,5 +12,5 @@ group :development, :test do gem "rubocop-rspec" gem "simplecov", require: false gem "vcr", "~> 6.2.0" - gem "webmock", "~> 3.18.1" + gem "webmock", "~> 3.18" end diff --git a/spec/asimov/api_v1/api_error_translator_spec.rb b/spec/asimov/api_v1/api_error_translator_spec.rb index b350aca..306e718 100644 --- a/spec/asimov/api_v1/api_error_translator_spec.rb +++ b/spec/asimov/api_v1/api_error_translator_spec.rb @@ -3,8 +3,7 @@ RSpec.describe Asimov::ApiV1::ApiErrorTranslator do let(:resp) do r = instance_double(HTTParty::Response) - allow(r).to receive(:code).and_return(code) - allow(r).to receive(:parsed_response).and_return(parsed_response) + allow(r).to receive_messages(code: code, parsed_response: parsed_response) r end diff --git a/spec/shared_examples/api_v1/httparty_client.rb b/spec/shared_examples/api_v1/httparty_client.rb index 52df437..d163019 100644 --- a/spec/shared_examples/api_v1/httparty_client.rb +++ b/spec/shared_examples/api_v1/httparty_client.rb @@ -10,8 +10,7 @@ let(:parsed_body) { { SecureRandom.hex(4) => SecureRandom.hex(4) } } let(:ret_val) do resp = instance_double(HTTParty::Response) - allow(resp).to receive(:code).and_return(200) - allow(resp).to receive(:parsed_response).and_return(parsed_body) + allow(resp).to receive_messages(code: 200, parsed_response: parsed_body) resp end