Test failures with dalli 2.3.0 #275

Closed
graaff opened this Issue Oct 17, 2012 · 2 comments

Projects

None yet

3 participants

@graaff
graaff commented Oct 17, 2012

I'm getting a number of test failures with dalli 2.3.0. As far as I can tell these are due to my system not running a default memcached instance. An excerpt of the errors is below. In total I get

85 tests, 13422 assertions, 0 failures, 14 errors, 4 skips

I'm trying to get these test in shape for Gentoo, so that we can update our package of dalli. In Gentoo we offer users the option to run tests when installing a package, but in that case I can't make the assumption that a default memcached instance is available, and due to permissions I can't start a default server. It looks like most of the other tests are working around this by starting their own instance of memcached, and that's fine. I wonder if that can be done here as well.

  1) Error:
test_0001_not allow blanks(Dalli::key validation):
Dalli::RingError: No server available
    /var/tmp/portage/dev-ruby/dalli-2.3.0/work/ruby19/dalli-2.3.0/lib/dalli/ring.rb:45:in `server_for_key'
    /var/tmp/portage/dev-ruby/dalli-2.3.0/work/ruby19/dalli-2.3.0/lib/dalli/client.rb:266:in `perform'
    /var/tmp/portage/dev-ruby/dalli-2.3.0/work/ruby19/dalli-2.3.0/lib/dalli/client.rb:119:in `set'
    /var/tmp/portage/dev-ruby/dalli-2.3.0/work/ruby19/dalli-2.3.0/test/test_dalli.rb:31:in `block (3 levels) in <top (required)>'
    /usr/lib64/ruby/gems/1.9.1/gems/mocha-0.12.7/lib/mocha/integration/mini_test/version_330_to_410.rb:32:in `run'

  2) Error:
test_0013_omits cookie with :defer option but still updates the state(Rack::Session::Dalli):
Dalli::RingError: No server available
    /var/tmp/portage/dev-ruby/dalli-2.3.0/work/ruby19/dalli-2.3.0/lib/dalli/ring.rb:45:in `server_for_key'
    /var/tmp/portage/dev-ruby/dalli-2.3.0/work/ruby19/dalli-2.3.0/lib/dalli/client.rb:266:in `perform'
    /var/tmp/portage/dev-ruby/dalli-2.3.0/work/ruby19/dalli-2.3.0/lib/dalli/client.rb:49:in `get'
    /var/tmp/portage/dev-ruby/dalli-2.3.0/work/ruby19/dalli-2.3.0/lib/rack/session/dalli.rb:24:in `block in generate_sid'
    /var/tmp/portage/dev-ruby/dalli-2.3.0/work/ruby19/dalli-2.3.0/lib/rack/session/dalli.rb:22:in `loop'
    /var/tmp/portage/dev-ruby/dalli-2.3.0/work/ruby19/dalli-2.3.0/lib/rack/session/dalli.rb:22:in `generate_sid'
    /usr/lib64/ruby/gems/1.9.1/gems/rack-1.4.1/lib/rack/session/abstract/id.rb:320:in `commit_session'
    /usr/lib64/ruby/gems/1.9.1/gems/rack-1.4.1/lib/rack/session/abstract/id.rb:206:in `context'
    /usr/lib64/ruby/gems/1.9.1/gems/rack-1.4.1/lib/rack/utils.rb:353:in `call'
    /usr/lib64/ruby/gems/1.9.1/gems/rack-1.4.1/lib/rack/mock.rb:72:in `request'
    /usr/lib64/ruby/gems/1.9.1/gems/rack-1.4.1/lib/rack/mock.rb:56:in `get'
    /var/tmp/portage/dev-ruby/dalli-2.3.0/work/ruby19/dalli-2.3.0/test/test_rack_session.rb:182:in `block (2 levels) in <top (required)>'
    /usr/lib64/ruby/gems/1.9.1/gems/mocha-0.12.7/lib/mocha/integration/mini_test/version_330_to_410.rb:32:in `run'

  3) Error:
test_0002_connects to existing server(Rack::Session::Dalli):
Dalli::RingError: No server available
    /var/tmp/portage/dev-ruby/dalli-2.3.0/work/ruby19/dalli-2.3.0/lib/dalli/ring.rb:45:in `server_for_key'
    /var/tmp/portage/dev-ruby/dalli-2.3.0/work/ruby19/dalli-2.3.0/lib/dalli/client.rb:266:in `perform'
    /var/tmp/portage/dev-ruby/dalli-2.3.0/work/ruby19/dalli-2.3.0/lib/dalli/client.rb:119:in `set'
    /var/tmp/portage/dev-ruby/dalli-2.3.0/work/ruby19/dalli-2.3.0/test/test_rack_session.rb:47:in `block (3 levels) in <top (required)>'


@ReubenM
ReubenM commented Oct 28, 2012

Hope this is not too OT, but if you make this available in Gentoo, would you consider trying to make the 1.1.x available as a slotted version as well? (2.x doesn't do unix domain sockets, among other differences)

@mperham mperham added a commit that referenced this issue Nov 13, 2012
@mperham mperham Fix tests [#275] 9488401
@mperham mperham closed this Nov 13, 2012
@graaff
graaff commented Nov 14, 2012

Removing stuff is always my favorite way to fix bugs :-) Confirmed that this is all fixed for me with dalli 2.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment