Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Dalli 2.6.2 fails tests without a default memcached running #336

Closed
graaff opened this Issue Mar 3, 2013 · 1 comment

Comments

Projects
None yet
2 participants

graaff commented Mar 3, 2013

Dalli 2.6.2 fails its tests:

  1) Error:
test_0001_default to Dalli::Compressor(Compressor):
Dalli::RingError: No server available
    ./lib/dalli/ring.rb:45:in `server_for_key'
    ./lib/dalli/client.rb:320:in `perform'
    ./lib/dalli/client.rb:173:in `set'
    /var/tmp/portage/dev-ruby/dalli-2.6.2/work/ruby18/dalli-2.6.2/test/test_compressor.rb:20:in `test_0001_default to Dalli::Compressor'

  2) Error:
test_0002_support a custom compressor(Compressor):
Dalli::RingError: No server available
    ./lib/dalli/ring.rb:45:in `server_for_key'
    ./lib/dalli/client.rb:320:in `perform'
    ./lib/dalli/client.rb:173:in `set'
    /var/tmp/portage/dev-ruby/dalli-2.6.2/work/ruby18/dalli-2.6.2/test/test_compressor.rb:26:in `test_0002_support a custom compressor'

  3) Error:
test_0001_default to Marshal(Serializer):
Dalli::RingError: No server available
    ./lib/dalli/ring.rb:45:in `server_for_key'
    ./lib/dalli/client.rb:320:in `perform'
    ./lib/dalli/client.rb:173:in `set'
    /var/tmp/portage/dev-ruby/dalli-2.6.2/work/ruby18/dalli-2.6.2/test/test_serializer.rb:10:in `test_0001_default to Marshal'

  4) Error:
test_0002_support a custom serializer(Serializer):
Dalli::RingError: No server available
    ./lib/dalli/ring.rb:45:in `server_for_key'
    ./lib/dalli/client.rb:320:in `perform'
    ./lib/dalli/client.rb:173:in `set'
    /var/tmp/portage/dev-ruby/dalli-2.6.2/work/ruby18/dalli-2.6.2/test/test_serializer.rb:16:in `test_0002_support a custom serializer'

When I start a default memcached then these tests pass. As far as I thought all tests actually use either a mock memcache or an instance that get started specifically for the tests. Is this an oversight, or do these tests really require the default memcached to be running?

Collaborator

mperham commented Mar 3, 2013

Those are recent tests. PR welcome.

On 3 Mar 2013, at 12:30, Hans de Graaff notifications@github.com wrote:

Dalli 2.6.2 fails its tests:

  1. Error:
    test_0001_default to Dalli::Compressor(Compressor):
    Dalli::RingError: No server available
    ./lib/dalli/ring.rb:45:in server_for_key' ./lib/dalli/client.rb:320:inperform'
    ./lib/dalli/client.rb:173:in set' /var/tmp/portage/dev-ruby/dalli-2.6.2/work/ruby18/dalli-2.6.2/test/test_compressor.rb:20:intest_0001_default to Dalli::Compressor'

  2. Error:
    test_0002_support a custom compressor(Compressor):
    Dalli::RingError: No server available
    ./lib/dalli/ring.rb:45:in server_for_key' ./lib/dalli/client.rb:320:inperform'
    ./lib/dalli/client.rb:173:in set' /var/tmp/portage/dev-ruby/dalli-2.6.2/work/ruby18/dalli-2.6.2/test/test_compressor.rb:26:intest_0002_support a custom compressor'

  3. Error:
    test_0001_default to Marshal(Serializer):
    Dalli::RingError: No server available
    ./lib/dalli/ring.rb:45:in server_for_key' ./lib/dalli/client.rb:320:inperform'
    ./lib/dalli/client.rb:173:in set' /var/tmp/portage/dev-ruby/dalli-2.6.2/work/ruby18/dalli-2.6.2/test/test_serializer.rb:10:intest_0001_default to Marshal'

  4. Error:
    test_0002_support a custom serializer(Serializer):
    Dalli::RingError: No server available
    ./lib/dalli/ring.rb:45:in server_for_key' ./lib/dalli/client.rb:320:inperform'
    ./lib/dalli/client.rb:173:in set' /var/tmp/portage/dev-ruby/dalli-2.6.2/work/ruby18/dalli-2.6.2/test/test_serializer.rb:16:intest_0002_support a custom serializer'
    When I start a default memcached then these tests pass. As far as I thought all tests actually use either a mock memcache or an instance that get started specifically for the tests. Is this an oversight, or do these tests really require the default memcached to be running?


Reply to this email directly or view it on GitHub.

@dfens dfens closed this in cf17e8c Apr 29, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment