Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Should Dalli warn on VALUE_TOO_LARGE error? #338

Closed
alevy opened this Issue Mar 7, 2013 · 2 comments

Comments

Projects
None yet
2 participants
Contributor

alevy commented Mar 7, 2013

Currently, if the client tries sets a value that's too large (1MB by default in memcached), Dalli simply returns false.

Does it make sense to log a warning to make debugging these cases in production easier?

If so, I'm happy to do a pull request (should be pretty simple code).

Collaborator

mperham commented Mar 7, 2013

Sounds fine to me. You can also turn on compression.

Contributor

alevy commented Mar 7, 2013

Well, in the particular case that prompted this, compression was already on. Cool, I'll have a pull request soon.

@mperham mperham closed this May 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment