Accommodate nil server setting via ActiveSupport #427

merged 1 commit into from Jan 14, 2014


None yet
2 participants

jjb commented Jan 14, 2014

This wasn't actually working before :). @servers would end up being [nil]

All tests pass if i had changed addresses = addresses.flatten to addresses = addresses.flatten.compact, but I felt it was more conservative to do it after the options parsing was done, just in case there were edge cases not covered in specs.

I threw in the server check in the "normalize options" test for good measure

@mperham mperham added a commit that referenced this pull request Jan 14, 2014

@mperham mperham Merge pull request #427 from jjb/allow-nil-server-config
Accommodate nil server setting via ActiveSupport

@mperham mperham merged commit 8ffda36 into petergoldstein:master Jan 14, 2014

1 check failed

default The Travis CI build failed

jjb deleted the jjb:allow-nil-server-config branch Jan 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment