Ipv6 address support #428

Merged
merged 4 commits into from Jan 16, 2014

Conversation

Projects
None yet
2 participants
@dplummer
Contributor

dplummer commented Jan 16, 2014

I found that you couldn't supply a raw IPv6 address because of the port and weight parsing in Dalli::Server. This PR adds tests around the parsing, and support for raw IPv6 addresses.

@mperham

This comment has been minimized.

Show comment Hide comment
@mperham

mperham Jan 16, 2014

Collaborator

Nice work, update the changelog?

Collaborator

mperham commented Jan 16, 2014

Nice work, update the changelog?

@dplummer

This comment has been minimized.

Show comment Hide comment
@dplummer

dplummer Jan 16, 2014

Contributor

Right! Also, I wasn't able to run the SASL tests, but I don't expect this will affect that.

Contributor

dplummer commented Jan 16, 2014

Right! Also, I wasn't able to run the SASL tests, but I don't expect this will affect that.

mperham added a commit that referenced this pull request Jan 16, 2014

@mperham mperham merged commit 0315451 into petergoldstein:master Jan 16, 2014

1 check failed

default The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment