Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Reduce code duplication in Dalli::Server #429

Merged
merged 3 commits into from Jan 23, 2014

Conversation

Projects
None yet
2 participants
Contributor

koraktor commented Jan 23, 2014

These patches try to improve the code quality of Dalli::Server by reducing the amount of duplicate code.

@mperham mperham and 1 other commented on an outdated diff Jan 23, 2014

lib/dalli/server.rb
@@ -548,6 +533,12 @@ def read(count)
end
end
+ def read_header
+ header = read(24)
@mperham

mperham Jan 23, 2014

Collaborator

read(24) || raise(Dalli::NetworkError, 'No response')

@koraktor

koraktor Jan 23, 2014

Contributor

Sounds good. I'll update the PR.

mperham added a commit that referenced this pull request Jan 23, 2014

Merge pull request #429 from koraktor/code-quality
Reduce code duplication in Dalli::Server

@mperham mperham merged commit 5794335 into petergoldstein:master Jan 23, 2014

1 check failed

default The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment