Moved doctrine knowledge into a manager class

The controller didn't need to know about the implementation
details of doctrine, it only needs to know that our application
can provide some blog posts objects. Therefore we introduce
a "Manager" class whose job it is to do that.

Author: peterjmit

spec/Peterjmit/BlogBundle/Controller/BlogControllerSpec.php

@@ -5,25 +5,18 @@
 use PhpSpec\ObjectBehavior;
 use Prophecy\Argument;
 
-use Doctrine\Common\Persistence\ManagerRegistry;
-use Doctrine\Common\Persistence\ObjectManager;
-use Doctrine\Common\Persistence\ObjectRepository;
+use Peterjmit\BlogBundle\Model\BlogManagerInterface;
 
 use Symfony\Bundle\FrameworkBundle\Templating\EngineInterface;
 use Symfony\Component\HttpFoundation\Response;
 
 class BlogControllerSpec extends ObjectBehavior
 {
     function let(
-        ManagerRegistry $registry,
-        ObjectManager $manager,
-        ObjectRepository $repository,
+        BlogManagerInterface $manager,
         EngineInterface $templating
     ) {
-        $registry->getManager()->willReturn($manager);
-        $manager->getRepository('PeterjmitBlogBundle:Blog')->willReturn($repository);
-
-        $this->beConstructedWith($registry, $templating);
+        $this->beConstructedWith($manager, $templating);
     }
 
     function it_is_initializable()
@@ -32,11 +25,11 @@ function it_is_initializable()
     }
 
     function it_should_respond_to_index_action(
-        ObjectRepository $repository,
+        BlogManagerInterface $manager,
         EngineInterface $templating,
         Response $mockResponse
     ) {
-        $repository->findAll()->willReturn(array());
+        $manager->findAll()->willReturn(array());
 
         $templating
             ->renderResponse(

src/Peterjmit/BlogBundle/Controller/BlogController.php

@@ -2,24 +2,23 @@
 
 namespace Peterjmit\BlogBundle\Controller;
 
-use Doctrine\Common\Persistence\ManagerRegistry;
+use Peterjmit\BlogBundle\Model\BlogManagerInterface;
 use Symfony\Bundle\FrameworkBundle\Templating\EngineInterface;
 
 class BlogController
 {
-    private $doctrine;
+    private $manager;
     private $templating;
 
-    public function __construct(ManagerRegistry $doctrine, EngineInterface $templating)
+    public function __construct(BlogManagerInterface $manager, EngineInterface $templating)
     {
-        $this->doctrine = $doctrine;
+        $this->manager = $manager;
         $this->templating = $templating;
     }
 
     public function indexAction()
     {
-        $entityManager = $this->doctrine->getManager();
-        $posts = $entityManager->getRepository('PeterjmitBlogBundle:Blog')->findAll();
+        $posts = $this->manager->findAll();
 
         return $this->templating->renderResponse('PeterjmitBlogBundle:Blog:index.html.twig', array(
             'posts' => $posts
@@ -28,8 +27,7 @@ public function indexAction()
 
     public function showAction($id)
     {
-        $entityManager = $this->doctrine->getManager();
-        $post = $entityManager->getRepository('PeterjmitBlogBundle:Blog')->find($id);
+        $post = $this->manager->find($id);
 
         if (!$post) {
             throw $this->createNotFoundException(sprintf('Blog post %s was not found', $id));

src/Peterjmit/BlogBundle/Model/BlogManagerInterface.php

@@ -0,0 +1,9 @@
+<?php
+
+namespace Peterjmit\BlogBundle\Model;
+
+interface BlogManagerInterface
+{
+    function findAll();
+    function find($id);
+}