Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Padding or borders on nested elements causes breakage #118
@dmitrykiselyov Sure, will do so in about an hour once I am back at a computer. I'll edit this comment with the code.
EDIT: Here's the problematic part of my Jade template when it wasn't working:
nav #content article #content
And the offending Stylus:
nav lost-column 1/4 padding 4rem article lost-column 3/4 padding 4rem
nav .wrap #content article .wrap #content
nav lost-column 1/4 .wrap padding 4rem article lost-column 3/4 .wrap padding 4rem
...this fixes the problem, and
They (nav and article) must have a parent (to know who is the last child and remove
.content nav #content1 article #content2
.content lost-utility clearfix nav lost-column 1/4 padding 4rem article lost-column 3/4 padding 4rem
Yep, and you don't have to do lost-utility clearfix if you don't want:
Will add in the clearfix and display: flex and everything for you. Sometimes just using the utility clearfix is good, but most of the time I find myself just using the lost-center.
@dmitrykiselyov Apologies...I should mention that
@AleksejDix I wasn't using the gutter variable like that because I didn't grasp exactly how it works just yet, and didn't think to use
padstuff = 4rem section lost-center 100% padstuff nav lost-column 1/4 margin-top padstuff article lost-column 3/4 margin-top padstuff
Thanks so much for your help, everyone. I've still got much to learn it seems :)
Sorry I was out of town all this past week.
@peterramsing thanks! yeah, a real documentation is great, altough it might take couple weeks (months?) until it is decided and implemented. maybe just make a quick change in the readme for now and dont think about it anymore? your call. ;)
there is no harm in doing so.