Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign uplost-align issue #233
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
peterramsing
Jan 13, 2016
Owner
@eybarta I might be misunderstanding this but it looks to be this works as expected. lost-align is intended to align the child elements. See here: lost-align
Align nested elements. Apply this to a parent container.
Please let me know if this I'm not understanding this correctly. Maybe some of the code you're working with? Thanks!
|
@eybarta I might be misunderstanding this but it looks to be this works as expected.
Please let me know if this I'm not understanding this correctly. Maybe some of the code you're working with? Thanks! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
corysimmons
Jan 13, 2016
Contributor
Crap, I think @eybarta is right. justify-content and align-items should be applied to the parent container instead of > *.
lost-align is broken when used with global flexbox or the flex param.
|
Crap, I think @eybarta is right.
|
corysimmons
added
type: Bug
needs: Work
and removed
resolution: Works as Expected
type: Question
labels
Jan 13, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Will look into this tonight. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adrian2x
Jan 13, 2016
I just noticed this too. I thing @eybarta is right too. Unlike the position-based alignment, the flex alignment properties should be applied on the container element, because they specify how a flex element arranges its items. The way that it is implemented right now, it will apply these properties (justify-content and align-items) to the actual children, which will make them in turn flex containers, according to the spec.
PR -> #236
adrian2x
commented
Jan 13, 2016
|
I just noticed this too. I thing @eybarta is right too. Unlike the position-based alignment, the flex alignment properties should be applied on the container element, because they specify how a flex element arranges its items. The way that it is implemented right now, it will apply these properties ( |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
eybarta
commented
Jan 14, 2016
|
glad this is being addressed |
corysimmons
added
needs: Review
and removed
needs: Work
labels
Jan 14, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
aguilera51284
commented
Jun 28, 2016
|
i have the same problem here :)! |
peterramsing
added
the
status: Slated For Dev
label
Nov 5, 2016
peterramsing
modified the milestone:
v8.0
Nov 6, 2016
peterramsing
self-assigned this
Nov 6, 2016
peterramsing
added
status: In Progress
and removed
status: Slated For Dev
labels
Nov 9, 2016
added a commit
that referenced
this issue
Nov 16, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
peterramsing
Nov 16, 2016
Owner
Fixed here: #339
You'll see this in the beta version soon and in LostGrid v8.
|
Fixed here: #339 You'll see this in the beta version soon and in LostGrid v8. |
eybarta commentedJan 13, 2016
•
edited by peterramsing
Thx for all your work, very refreshing using this grid and thx Peter for maintaining!
I'm not sure if I'm doing something wrong.. but using
lost-alignon a parent seems to give thejustify-contentandalign-itemsproperties to the children instead of the parent resulting in incorrect behavior.. I looked @ lost/lib/lost-align.js and it seems the conditional styles are always given to ' > * ',am I misunderstanding something or is this a bug?