Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Lost-column/waffle float:right to last cycle unexpected outcome #328
Is this a feature request or a bug report?
What is the current behavior?
If it's a bug please provide the steps to reproduce it and maybe some code samples.
Just add any number of elements in a view, place a "lost-column: 1/4 2" (or a lost-waffle, with a cycle smaller than the denominator) and look at the outcome, the second "column" of elements gets pushed to the right side of the screen due to the float, instead of leaving the space that was specified in the 2nd cycle. This worked perfectly in versions prior to 6.7.0.
What is the behavior that you expect?
The behaviour present before 6.7.0, in which cycles dont get pushed to the right
What's the motivation or use-case behind changing the behavior?
Restore this great grid system's behaviour
What version of LostGrid, browser and browser version are affected by this issue? Did this happen in previous versions?
I checked it in Safari and Chrome on Mac, It did not happen before 6.7.0.
This is my html/scss
This is the outcome
If i remove the float:right to the last cycle, this happens (what i believe should happen)
I am not doing a pull request myself removing the float:right from the source because that would simply re-open issue #200
@akoury I see where you're going with this. As a people pleaser, doing Open Source work on large projects is really tough. I want everyone happy.
That said, thank you so much for this issue! You're the type of person that makes Open Source really fun! This is a really well thought out issue.
If I knew this would cause any breaking changes I would have certainly done #218 as a major release. I'm sorry.
My first thought is to make this a option for
@peterramsing please dont apologize! your work here has been great and you are not even getting compensated for this, so know that everything you do is greatly appreciated.
Regarding the issue: like i said, i could've made a pull request just removing the float right from both lost-waffle and lost-column files, however i think that would just make the previous issue #200 reappear, so i dont know if a toggeable option would be a perfect fit.
Sorry that i don't have much to contribute regarding ideas on how to solve it, I am very new to this field, maybe @corysimmons has some ideas on what could be done hehe
(I tried removing the float:right for testing and i see that issue #200 reappears, even in Chrome, not just Safari :( )
@peterramsing Why don't we break out all the params for these various things into their own properties (as well as keeping shorthand)?
Lost keeps needing more params to help with various use cases, but
lost-column-fraction: 1/4; lost-column-gutter: 45px; lost-column-cycle: 3;
etc... is a lot more readable/composable.
It'd let us tack these features on left and right (after discussing their value as a param of course).
Really, the only way I see to address the plethora of use-cases is to add more params/settings/etc. /shrug
I think that I'm going to remove the float as standard for
You'll see this change in LostGrid v8.