New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a float to the last cycle of the div in Lost-Column and Lost-Waffle #218

Merged
merged 20 commits into from Jan 11, 2016

Conversation

Projects
None yet
4 participants
@peterramsing
Owner

peterramsing commented Dec 31, 2015

  • Add this to lost-column
  • Add this to lost-waffle

See #200

@peterramsing peterramsing self-assigned this Jan 2, 2016

@peterramsing peterramsing changed the title from Adds a float to the last cycle of the div in Lost-Column and Lost-Waffle to WIP: Adds a float to the last cycle of the div in Lost-Column and Lost-Waffle Jan 2, 2016

@peterramsing

This comment has been minimized.

Show comment
Hide comment
@peterramsing

peterramsing Jan 2, 2016

Owner

@bradryanbice - if you want to pull this down and test it to see if it solves your issue you're more than welcome to. I'll get to the lost-waffle rule (or someone else can?) in the coming weeks. Hoping 6.7.0 by mid/late January. If only I had more hours in the day. 😄

Owner

peterramsing commented Jan 2, 2016

@bradryanbice - if you want to pull this down and test it to see if it solves your issue you're more than welcome to. I'll get to the lost-waffle rule (or someone else can?) in the coming weeks. Hoping 6.7.0 by mid/late January. If only I had more hours in the day. 😄

peterramsing added some commits Jan 4, 2016

Merge pull request #223 from peterramsing/6.6.4
Merge 6.6.4 into 6.7.0 as it ended up being only docs changes
Merge pull request #211 from peterramsing/unset-lost-column-rule
Adds the rule "none" to the "lost-column" property to set it back to browser defaults.
@bradryanbice

This comment has been minimized.

Show comment
Hide comment
@bradryanbice

bradryanbice Jan 4, 2016

Thanks all, I'll take a look.

bradryanbice commented Jan 4, 2016

Thanks all, I'll take a look.

@peterramsing

This comment has been minimized.

Show comment
Hide comment
@peterramsing

peterramsing Jan 8, 2016

Owner

@bradryanbice Any updates on if this helped? Should be finishing this up soon.

Owner

peterramsing commented Jan 8, 2016

@bradryanbice Any updates on if this helped? Should be finishing this up soon.

@bradryanbice

This comment has been minimized.

Show comment
Hide comment
@bradryanbice

bradryanbice Jan 8, 2016

The float:right fix worked for me in getting rid of the 1px sliver. However I have not had a chance to test to extensively beyond my initial example.

bradryanbice commented Jan 8, 2016

The float:right fix worked for me in getting rid of the 1px sliver. However I have not had a chance to test to extensively beyond my initial example.

@peterramsing

This comment has been minimized.

Show comment
Hide comment
@peterramsing

peterramsing Jan 8, 2016

Owner

@bradryanbice Cool. I'm going to be doing some more tests with 6.7.0 this weekend + coming week but glad to know it at least appears to be on the right track! Thanks for submitting the issue!

Owner

peterramsing commented Jan 8, 2016

@bradryanbice Cool. I'm going to be doing some more tests with 6.7.0 this weekend + coming week but glad to know it at least appears to be on the right track! Thanks for submitting the issue!

@bradryanbice

This comment has been minimized.

Show comment
Hide comment
@bradryanbice

bradryanbice Jan 8, 2016

Absolutely, thanks for being on top of this. Nice to see such great support.

bradryanbice commented Jan 8, 2016

Absolutely, thanks for being on top of this. Nice to see such great support.

@peterramsing

This comment has been minimized.

Show comment
Hide comment
@peterramsing

peterramsing Jan 8, 2016

Owner

@bradryanbice Certainly trying to do the best we can. 😄

Owner

peterramsing commented Jan 8, 2016

@bradryanbice Certainly trying to do the best we can. 😄

peterramsing added some commits Jan 9, 2016

Adds gotcha note for Less and fractions
As noted in issue #229 there can be an issue where Less does the
division of lost-column: 1/2 into lost-column: 0.5 which causes
problems especially with cycle. This adds a note to escape the division
with a ~”1/2”.
Adds a float: right to the lost-waffle feature
Due to sub-pixel rounding there has been some issues where the last
element in a cycle (or row) would have a small bit of space visible to
the right of it inside the container that surrounded it.

Most notably, this issue occurred in Safari 9 for iOS and Desktop.
@peterramsing

This comment has been minimized.

Show comment
Hide comment
@peterramsing

peterramsing Jan 10, 2016

Owner

This should be good to go. I want to do some more testing to triple check there are no issues a bit more but this should be good to go.

@bradryanbice Any additional feedback on this?

Owner

peterramsing commented Jan 10, 2016

This should be good to go. I want to do some more testing to triple check there are no issues a bit more but this should be good to go.

@bradryanbice Any additional feedback on this?

@peterramsing peterramsing changed the title from WIP: Adds a float to the last cycle of the div in Lost-Column and Lost-Waffle to Adds a float to the last cycle of the div in Lost-Column and Lost-Waffle Jan 10, 2016

peterramsing added a commit that referenced this pull request Jan 11, 2016

Merge pull request #218 from peterramsing/add-float-to-last-cycle-div
Adds a float to the last cycle of the div in Lost-Column and Lost-Waffle

@peterramsing peterramsing merged commit 55be887 into 6.7.0 Jan 11, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@peterramsing peterramsing deleted the add-float-to-last-cycle-div branch Jan 11, 2016

@corysimmons

This comment has been minimized.

Show comment
Hide comment
@corysimmons

corysimmons Jan 11, 2016

Contributor

🎉

Contributor

corysimmons commented Jan 11, 2016

🎉

@alex-ketch

This comment has been minimized.

Show comment
Hide comment
@alex-ketch

alex-ketch Jan 11, 2016

Thought I'd chip in as this seems to be working for me too.
Attached screenshot before and after.

For some reason it was mainly happening on the middle column, even though the widths for the side columns was also 1px short of the parent container's width.

Before
Before using 6.7.0

After
After using 6.7.0

Of note is that I had to remove lost-offset, but could be a consequence of some other styling.

h1 {
  lost-column: 9/10 1;
  lost-offset: -1/10;
}

to

h1 {
  lost-column: 9/10 1;
}

Edit: Noticed I was a bit late to the party and it's already been merged :)

alex-ketch commented Jan 11, 2016

Thought I'd chip in as this seems to be working for me too.
Attached screenshot before and after.

For some reason it was mainly happening on the middle column, even though the widths for the side columns was also 1px short of the parent container's width.

Before
Before using 6.7.0

After
After using 6.7.0

Of note is that I had to remove lost-offset, but could be a consequence of some other styling.

h1 {
  lost-column: 9/10 1;
  lost-offset: -1/10;
}

to

h1 {
  lost-column: 9/10 1;
}

Edit: Noticed I was a bit late to the party and it's already been merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment