-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a float to the last cycle of the div in Lost-Column and Lost-Waffle #218
Conversation
Indent style should be a space Indent size should be 2
Adds Editor Config to project
@bradryanbice - if you want to pull this down and test it to see if it solves your issue you're more than welcome to. I'll get to the |
Merge 6.6.4 into 6.7.0 as it ended up being only docs changes
Adds the rule "none" to the "lost-column" property to set it back to browser defaults.
Thanks all, I'll take a look. |
@bradryanbice Any updates on if this helped? Should be finishing this up soon. |
The float:right fix worked for me in getting rid of the 1px sliver. However I have not had a chance to test to extensively beyond my initial example. |
@bradryanbice Cool. I'm going to be doing some more tests with 6.7.0 this weekend + coming week but glad to know it at least appears to be on the right track! Thanks for submitting the issue! |
Absolutely, thanks for being on top of this. Nice to see such great support. |
@bradryanbice Certainly trying to do the best we can. 😄 |
As noted in issue #229 there can be an issue where Less does the division of lost-column: 1/2 into lost-column: 0.5 which causes problems especially with cycle. This adds a note to escape the division with a ~”1/2”.
Due to sub-pixel rounding there has been some issues where the last element in a cycle (or row) would have a small bit of space visible to the right of it inside the container that surrounded it. Most notably, this issue occurred in Safari 9 for iOS and Desktop.
This should be good to go. I want to do some more testing to triple check there are no issues a bit more but this should be good to go. @bradryanbice Any additional feedback on this? |
Adds a float to the last cycle of the div in Lost-Column and Lost-Waffle
🎉 |
Thought I'd chip in as this seems to be working for me too. For some reason it was mainly happening on the middle column, even though the widths for the side columns was also 1px short of the parent container's width. Of note is that I had to remove h1 {
lost-column: 9/10 1;
lost-offset: -1/10;
} to h1 {
lost-column: 9/10 1;
} Edit: Noticed I was a bit late to the party and it's already been merged :) |
lost-column
lost-waffle
See #200