Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a float to the last cycle of the div in Lost-Column and Lost-Waffle #218

Merged
merged 20 commits into from Jan 11, 2016

Conversation

@peterramsing
Copy link
Owner

peterramsing commented Dec 31, 2015

  • Add this to lost-column
  • Add this to lost-waffle

See #200

@peterramsing peterramsing self-assigned this Jan 2, 2016
Adds Editor Config to project
@peterramsing peterramsing changed the title Adds a float to the last cycle of the div in Lost-Column and Lost-Waffle WIP: Adds a float to the last cycle of the div in Lost-Column and Lost-Waffle Jan 2, 2016
@peterramsing
Copy link
Owner Author

peterramsing commented Jan 2, 2016

@bradryanbice - if you want to pull this down and test it to see if it solves your issue you're more than welcome to. I'll get to the lost-waffle rule (or someone else can?) in the coming weeks. Hoping 6.7.0 by mid/late January. If only I had more hours in the day. 😄

peterramsing added 4 commits Jan 4, 2016
Merge 6.6.4 into 6.7.0 as it ended up being only docs changes
Adds the rule "none" to the "lost-column" property to set it back to browser defaults.
@bradryanbice
Copy link

bradryanbice commented Jan 4, 2016

Thanks all, I'll take a look.

@peterramsing
Copy link
Owner Author

peterramsing commented Jan 8, 2016

@bradryanbice Any updates on if this helped? Should be finishing this up soon.

@bradryanbice
Copy link

bradryanbice commented Jan 8, 2016

The float:right fix worked for me in getting rid of the 1px sliver. However I have not had a chance to test to extensively beyond my initial example.

@peterramsing
Copy link
Owner Author

peterramsing commented Jan 8, 2016

@bradryanbice Cool. I'm going to be doing some more tests with 6.7.0 this weekend + coming week but glad to know it at least appears to be on the right track! Thanks for submitting the issue!

@bradryanbice
Copy link

bradryanbice commented Jan 8, 2016

Absolutely, thanks for being on top of this. Nice to see such great support.

@peterramsing
Copy link
Owner Author

peterramsing commented Jan 8, 2016

@bradryanbice Certainly trying to do the best we can. 😄

peterramsing added 6 commits Jan 9, 2016
As noted in issue #229 there can be an issue where Less does the
division of lost-column: 1/2 into lost-column: 0.5 which causes
problems especially with cycle. This adds a note to escape the division
with a ~”1/2”.
Due to sub-pixel rounding there has been some issues where the last
element in a cycle (or row) would have a small bit of space visible to
the right of it inside the container that surrounded it.

Most notably, this issue occurred in Safari 9 for iOS and Desktop.
@peterramsing
Copy link
Owner Author

peterramsing commented Jan 10, 2016

This should be good to go. I want to do some more testing to triple check there are no issues a bit more but this should be good to go.

@bradryanbice Any additional feedback on this?

@peterramsing peterramsing changed the title WIP: Adds a float to the last cycle of the div in Lost-Column and Lost-Waffle Adds a float to the last cycle of the div in Lost-Column and Lost-Waffle Jan 10, 2016
peterramsing added a commit that referenced this pull request Jan 11, 2016
Adds a float to the last cycle of the div in Lost-Column and Lost-Waffle
@peterramsing peterramsing merged commit 55be887 into 6.7.0 Jan 11, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@peterramsing peterramsing deleted the add-float-to-last-cycle-div branch Jan 11, 2016
@corysimmons
Copy link
Contributor

corysimmons commented Jan 11, 2016

🎉

@alex-ketch
Copy link

alex-ketch commented Jan 11, 2016

Thought I'd chip in as this seems to be working for me too.
Attached screenshot before and after.

For some reason it was mainly happening on the middle column, even though the widths for the side columns was also 1px short of the parent container's width.

Before
Before using 6.7.0

After
After using 6.7.0

Of note is that I had to remove lost-offset, but could be a consequence of some other styling.

h1 {
  lost-column: 9/10 1;
  lost-offset: -1/10;
}

to

h1 {
  lost-column: 9/10 1;
}

Edit: Noticed I was a bit late to the party and it's already been merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.