Updates rules with multiple cloneBefore uses to use cloneAllBefore #251

Merged
merged 1 commit into from Jan 27, 2016

Conversation

Projects
None yet
3 participants
@peterramsing
Owner

peterramsing commented Jan 26, 2016

This only adds this functionality to rules that have multiple uses to
make it a bit easier to read the code.

From #248 and @Adrianca

Updates rules with multiple cloneBefore uses to use cloneAllBefore
This only adds this functionality to rules that have multiple uses to
make it a bit easier to read the code.
@corysimmons

This comment has been minimized.

Show comment
Hide comment
@corysimmons

corysimmons Jan 26, 2016

Contributor

Love this

Contributor

corysimmons commented Jan 26, 2016

Love this

peterramsing added a commit that referenced this pull request Jan 27, 2016

Merge pull request #251 from peterramsing/add-cloneAllBefore
Updates rules with multiple cloneBefore uses to use cloneAllBefore

@peterramsing peterramsing merged commit 785ab6f into 7.0.0 Jan 27, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@adrian2x

This comment has been minimized.

Show comment
Hide comment
@adrian2x

adrian2x Feb 12, 2016

hey glad to see this being used, sorry I went missing for a while, I started a new project at work and time was not abundant but I should be able to set some time aside to contribute more in the coming month or so. Just some feedback here, maybe cloneAllBefore should be a module that files can require-in; instead of having it declared in multiple places?

hey glad to see this being used, sorry I went missing for a while, I started a new project at work and time was not abundant but I should be able to set some time aside to contribute more in the coming month or so. Just some feedback here, maybe cloneAllBefore should be a module that files can require-in; instead of having it declared in multiple places?

@peterramsing

This comment has been minimized.

Show comment
Hide comment
@peterramsing

peterramsing Feb 17, 2016

Owner

@Adrianca Totally fine. I've been swamped at work and with family these last few weeks so no worries. I like this module idea a lot.

hmm. I'll make a note.

Owner

peterramsing commented Feb 17, 2016

@Adrianca Totally fine. I've been swamped at work and with family these last few weeks so no worries. I like this module idea a lot.

hmm. I'll make a note.

@peterramsing peterramsing deleted the add-cloneAllBefore branch May 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment