Updates the "clear" rule from "left" to "both" #297

Merged
merged 6 commits into from May 31, 2016

Conversation

Projects
None yet
1 participant
@peterramsing
Owner

peterramsing commented May 31, 2016

Reference #293 for origional PR

What kind of change is this? (Bug Fix, Feature...)
Bug Fix

What is the current behavior (You can also link to an issue)
Currently, in lost-column and lost-grid this happens for the following code:

section {
    lost-center: 940px 10px;
    lost-utility: edit;
}

section .col-1-2 {
  lost-column/waffle: 1/2;
  margin-bottom: 21px;
  height: 80px;
}
section .second {
  height: 120px;
}
section .col-1-2:nth-child(2n + 1) {
    clear: left;
}

image

What is the new behavior this introduces (if any)

section .col-1-2 {
  lost-column/waffle: 1/2;
}
section .col-1-2:nth-child(2n + 1) {
    clear: both;
}

image

Does this introduce any breaking changes?
Yes. clear: left is now clear: both.
The update path if this causes undesired changes is to update @lost clearing left; to revert to the previous behavior.

Does the PR fulfill these requirements?

  • Tests for the changes have been added
  • Docs have been added or updated

Other Comments
See: #276

@peterramsing peterramsing changed the title from Add clear both to Updates the "clear" rule from "left" to "both" May 31, 2016

@peterramsing peterramsing self-assigned this May 31, 2016

@peterramsing peterramsing referenced this pull request May 31, 2016

Closed

Updates the "clear" rule from "left" to "both" #293

2 of 2 tasks complete

@peterramsing peterramsing merged commit a91f60b into beta May 31, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@peterramsing peterramsing deleted the add-clear-both branch May 31, 2016

@peterramsing peterramsing referenced this pull request Jul 6, 2016

Merged

Removes tests/hacks not needed since #312 #313

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment