New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ESLint with airbnb #324

Merged
merged 22 commits into from Aug 29, 2016

Conversation

@peterramsing
Owner

peterramsing commented Aug 22, 2016

What kind of change is this? (Bug Fix, Feature...)

What is the current behavior (You can also link to an issue)

What is the new behavior this introduces (if any)

  • Enables ESLint with airbnb rules
  • Refactors codebase to reflect lint
  • [=>] Add linting to tests (removing from this initial scope)
  • Update contribution docs

Does this introduce any breaking changes?

Does the PR fulfill these requirements?

  • [N/A] Tests for the changes have been added
  • Docs have been added or updated

Other Comments

peterramsing added some commits Aug 17, 2016

Updates the cloneAllBefore function for esLint
This reduces the need for the for loop, ultimately helping with
performance.

peterramsing added some commits Aug 24, 2016

peterramsing added some commits Aug 24, 2016

Revert "Adds ESLint task to test script"
This is because of some node issues and that's a task for a later time.

This reverts commit c68895b.
@peterramsing

This comment has been minimized.

Show comment
Hide comment
@peterramsing

peterramsing Aug 29, 2016

Owner

I had some issues getting Travis to run ESLint. I think it's because of #318. I'm going to keep looking into that as I'd like to have ESLint a part of the build process.

Owner

peterramsing commented Aug 29, 2016

I had some issues getting Travis to run ESLint. I think it's because of #318. I'm going to keep looking into that as I'd like to have ESLint a part of the build process.

@peterramsing peterramsing changed the title from WIP: Adds ESLint with airbnb to Adds ESLint with airbnb Aug 29, 2016

@peterramsing peterramsing merged commit 5424b40 into master Aug 29, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@peterramsing peterramsing deleted the eslint branch Aug 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment