New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates lost-offset to be more intuitively | #184 #331

Merged
merged 1 commit into from Oct 19, 2016

Conversation

Projects
None yet
1 participant
@peterramsing
Owner

peterramsing commented Oct 19, 2016

What kind of change is this? (Bug Fix, Feature...)
Update

This reverses the current api from moving left to right based on
negative fractions which didn’t make much sense. This breaks that
api’s current functionality and makes it more intuitive

Does this introduce any breaking changes?
🚨 Yes

Does the PR fulfill these requirements?

  • Tests for the changes have been added
  • Docs have been added or updated (not yet)
Updates lost-offset to be more intuitively | #184
This reverses the current api from moving left to right based on
negative fractions which didn’t make much sense. This breaks that
api’s current functionality and makes it more intuitive

@peterramsing peterramsing merged commit f46a75b into beta Oct 19, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@peterramsing peterramsing deleted the 184 branch Oct 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment