New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable Units in the calc. #345

Merged
merged 9 commits into from Nov 18, 2016

Conversation

Projects
None yet
1 participant
@peterramsing
Owner

peterramsing commented Nov 17, 2016

What kind of change is this? (Bug Fix, Feature...)
Feature Add

What is the current behavior (You can also link to an issue)
Only percentages

What is the new behavior this introduces (if any)
vw, vh, or % can be used in the calc

Does this introduce any breaking changes?
Trying to not.

Todo

  • Add validator to ensure only the correct units are used and add a warning if the incorrect one is used. (yay first use of warnings!) ( #180 )
  • lost-column
  • lost-row
  • lost-waffle

Does the PR fulfill these requirements?

  • Tests for the changes have been added
  • Docs have been added or updated

Other Comments

@peterramsing peterramsing changed the title from WIP: Customizable Units in the calc. to Customizable Units in the calc. Nov 18, 2016

@peterramsing peterramsing merged commit e79dcfa into beta Nov 18, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@peterramsing peterramsing deleted the vw-vh-units branch Nov 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment