Skip to content

Update getrawtransaction to work with block hash argument #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Update getrawtransaction to work with block hash argument #268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions bitcoin/rpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,24 +566,30 @@ def getrawmempool(self, verbose=False):
r = [lx(txid) for txid in r]
return r

def getrawtransaction(self, txid, verbose=False):
def getrawtransaction(self, txid, verbose=False, block_hash=None):
"""Return transaction with hash txid

Raises IndexError if transaction not found.

verbose - If true a dict is returned instead with additional
information on the transaction.

block_hash - Hash of the block containing the transaction
(required when transaction not currently indexed by Bitcoin Core)

Note that if all txouts are spent and the transaction index is not
enabled the transaction may not be available.
"""
try:
r = self._call('getrawtransaction', b2lx(txid), 1 if verbose else 0)
if block_hash is None:
r = self._call('getrawtransaction', b2lx(txid), 1 if verbose else 0)
else:
r = self._call('getrawtransaction', b2lx(txid), 1 if verbose else 0, b2lx(block_hash))
except InvalidAddressOrKeyError as ex:
raise IndexError('%s.getrawtransaction(): %s (%d)' %
(self.__class__.__name__, ex.error['message'], ex.error['code']))
if verbose:
r['tx'] = CTransaction.deserialize(unhexlify_str(r['hex']))
r['tx'] = CTransaction.deserialize(unhexlify(r['hex']))
del r['hex']
del r['txid']
del r['version']
Expand All @@ -592,8 +598,7 @@ def getrawtransaction(self, txid, verbose=False):
del r['vout']
r['blockhash'] = lx(r['blockhash']) if 'blockhash' in r else None
else:
r = CTransaction.deserialize(unhexlify_str(r))

r = CTransaction.deserialize(unhexlify(r))
return r

def getreceivedbyaddress(self, addr, minconf=1):
Expand Down