Enable OBJECT and STATIC libraries for Zend and extensions #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for testing purposes for now and to see how this behaves and if this would work ok. This enables having extensions, as STATIC, SHARED, MODULE, and OBJECT libraries. And Zend can be also STATIC. STATIC libraries are linked with WHOLE_ARCHIVE feature (--whole-archive and other linker flags) but this is more like a cutting edge feature of linkers and probably not yet very portable solution, so Zend OBJECT library is still a better way here to go with current state of the php-src. Additionally, always enabled extensions are marked as OBJECT libraries to make it clearer. Fixes GH-3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for testing purposes for now and to see how this behaves and if this would work ok. This enables having extensions, as STATIC, SHARED, MODULE, and OBJECT libraries. And Zend can be also STATIC.
STATIC libraries are linked with WHOLE_ARCHIVE feature (--whole-archive and other linker flags) but this is more like a cutting edge feature of linkers and probably not yet very portable solution, so Zend OBJECT library is still a better way here to go with current state of the php-src.
Additionally, always enabled extensions are marked as OBJECT libraries to make it clearer.
Fixes GH-3