New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

callback-baseline parallel benchmark is broken in Node 6.x #1165

Closed
edsadr opened this Issue Jul 18, 2016 · 0 comments

Comments

Projects
None yet
2 participants
@edsadr

edsadr commented Jul 18, 2016

(This issue tracker is only for bug reports or feature requests, if this is neither, please choose appropriate channel from http://bluebirdjs.com/docs/support.html)

Please answer the questions the best you can:

  1. What version of bluebird is the issue happening on?
    3.4.1

  2. What platform and version? (For example Node.js 0.12 or Google Chrome 32)
    Node v6.x

  3. Did this issue happen with earlier version of bluebird?
    yes

The callback-baseline test in parallel benchmark is broken, it fails with this callstack:

benchmarking ./madeup-parallel/callbacks-baseline.js
timers.js:314
    throw new TypeError('"callback" argument must be a function');
    ^

TypeError: "callback" argument must be a function
    at exports.setTimeout (timers.js:314:11)
    at Object.dummy_n (/Users/edsadr/Sites/bluebird/benchmark/lib/dummy.js:7:13)
    at Timeout.onComplete (/Users/edsadr/Sites/bluebird/benchmark/madeup-parallel/callbacks-baseline.js:21:24)
    at tryOnTimeout (timers.js:224:11)
    at Timer.listOnTimeout (timers.js:198:5)
benchmarking ./madeup-parallel/callbacks-caolan-async-parallel.js
timers.js:314
    throw new TypeError('"callback" argument must be a function');
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment