Promise.coroutine: yielding a function should not call the function #1314

giltayar · 2017-01-04T14:52:15Z

What version of bluebird is the issue happening on?
3.4.7
What platform and version? (For example Node.js 0.12 or Google Chrome 32)
Tested on Node 7, but I'm guessing it's true for all platforms
Did this issue happen with earlier version of bluebird?
Probably.

Given:

(Promise.coroutine(function*() {
  yield function () { console.log('hi'); };
}))();

You would not expect "hi" to be written to log, because we're yielding a value (which is a function), and not calling the function.

But it does print "hi". And then returns a rejected error.

I have prepared a pull-request that contains a fix, which I will submit in a few minutes.

…tion When rejecting a non-promise value, string.replace is used, and the value is passed as second parameter. But string.replace, if the second value is a function, will call that function. This commit fixes this by using value.toString().

benjamingr · 2017-01-04T16:35:43Z

Fix LGTM. @petkaantonov ptal.

petkaantonov · 2017-01-04T16:55:18Z

+ "" is sufficient

benjamingr · 2017-01-04T17:04:12Z

Or String(value)

giltayar · 2017-01-05T06:55:39Z

I chose @benjamingr's change - it seems more explicit to me. Thanks for pointing the (I hope slightly) awkward code out.

benjamingr closed this as completed in 0566325 Jan 27, 2017

Promise.coroutine: yielding a function should not call the function #1314

Promise.coroutine: yielding a function should not call the function #1314

giltayar commented Jan 4, 2017

benjamingr commented Jan 4, 2017

petkaantonov commented Jan 4, 2017

benjamingr commented Jan 4, 2017

giltayar commented Jan 5, 2017

Promise.coroutine: yielding a function should not call the function #1314

Promise.coroutine: yielding a function should not call the function #1314

Comments

giltayar commented Jan 4, 2017

benjamingr commented Jan 4, 2017

petkaantonov commented Jan 4, 2017

benjamingr commented Jan 4, 2017

giltayar commented Jan 5, 2017