New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PromiseArray rejection handler only handles one rejected promise #138

Closed
jparker-hbo opened this Issue Mar 11, 2014 · 0 comments

Comments

Projects
None yet
1 participant
@jparker-hbo

jparker-hbo commented Mar 11, 2014

Change afa323b fixed issue #135 so now this situation is no longer unhandled:

Promise.all([Promise.rejected("one")]).catch(...);

But if you do two or more, only the first one is handled:

Promise.all([Promise.rejected("one"), Promise.rejected("two")]).catch(...);

I'm not sure what the right behavior is, but maybe the first rejection should call the array's reject handler and then any other rejections are ignored?

jparker-hbo added a commit to HBOCodeLabs/bluebird that referenced this issue Mar 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment