Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugging with Chrome async stack traces #542

Closed
Artazor opened this issue Mar 23, 2015 · 2 comments
Closed

Debugging with Chrome async stack traces #542

Artazor opened this issue Mar 23, 2015 · 2 comments

Comments

@Artazor
Copy link
Contributor

@Artazor Artazor commented Mar 23, 2015

Copied from #415

[offtopic: sorry about asking here, but what is the status of the https://github.com/sparhami/bluebirdBreaksAsyncStackTraces - is the Bluebird chrome-async-stack-frame-friendly? if not - maybe it worth to introduce some flag that prevents grouping of unrelated promises for debugging purposes?]

I was unaware of such an issue but as far as I can see it could be easily solved by skipping the trampoline when running under debug mode

@petkaantonov can you elaborate? It would be extremely useful (and maybe worth to be mentioned in documentation)

@petkaantonov
Copy link
Owner

@petkaantonov petkaantonov commented Mar 23, 2015

It's a fix that needs to be done inside bluebird, not something that you can fix from outside

@petkaantonov
Copy link
Owner

@petkaantonov petkaantonov commented Mar 29, 2015

Fixed in 2.9.17

petkaantonov added a commit that referenced this issue Mar 29, 2015
By skipping trampoline when longStackTraces are enabled
in chrome there is no performance effect to server code
and client side debuggability is not harmed.

Fixes #542
Artazor referenced this issue Mar 30, 2015
This fixes bug where bluebird is not usable in chrome unless
long stack traces are enabled.

Fixes #551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants