Can't switch off Debug mode

[vitaly-t]

Using the latest version, can no longer switch off the long-stack tracing, or the entire debug mode for that matter:

• setting BLUEBIRD_DEBUG=0 - no effect;
• setting NODE_ENV=production - no effect.

Had to go manually comment some code out to make the long-stack tracing go away:

var debugging = false/* || (util.isNode &&
                    (!!process.env["BLUEBIRD_DEBUG"] ||
                     process.env["NODE_ENV"] === "development"))*/;

what's going on???!!!

[spion]

Works fine here. My guess is that something in your environment is turning on BLUEBIRD_DEBUG or is setting the NODE_ENV to development. I'd suggest to grep for process.env

If you want to disable BLUEBIRD_DEBUG you either have to unset it or set it to an empty string e.g. BLUEBIRD_DEBUG=''. That wont help if something is setting NODE_ENV though.

[vitaly-t]

I did debugging for this thing, and I found that if I set BLUEBIRD_DEBUG=0, then when your code calls !!process.env["BLUEBIRD_DEBUG"], that expression is true, because !! applied to a string that contains "0" is true.

That's a clear bug. Please re-open the issue.

[spion]

Reopening because accepting BLUEBIRD_DEBUG=1 to enable but not accepting BLUEBIRD_DEBUG=0 to disable long stack traces is bad UX.

There are a few things we might want to consider:

If the value is "0", should that override NODE_ENV?

Resulting logic would be process.env.hasOwnProperty("BLUEBIRD_DEBUG") ? isTruthy(process.env["BLUEBIRD_DEBUG"]) : process.env["NODE_ENV"] == "development"

If the value is anything other than "0" (e.g. "false" etc) should we handle those cases too?

isTruthy would handle this - if we decide to only accept "0" it would simply be !!arg && arg != "0"

[vitaly-t]

There was a breaking change in one of the recent releases, because I've been using BLUEBIRD_DEBUG=0 for a while, as was suggested to me here a while ago, and it worked. It stopped recently, not sure when exactly, I just noticed by accident that my tests on Travis where I used BLUEBIRD_DEBUG=0 started showing huge slow-down, so I went investigating till found the culprit.

[spion]

@vitaly-t if thats the case, then which is the version that accepts BLUEBIRD_DEBUG=0 ? I checked and equivalent logic goes back at least 6 months.

As far as I know, BLUEBIRD_DEBUG=0 has never worked - what has worked was unset BLUEBIRD_DEBUG and BLUEBIRD_DEBUG=''