We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
var rj = Promise.reject(new Error()); rj .return(Promise.join(rj)) .spread(console.log) .catch(console.error);
Gives an "Unhandled rejection Error" with Bluebird 2.9.34.
The example seems freakish, but it is a distilled version of a more complex scenario where the join has more arguments.
My first thought was to swap a simple array for the join, but add another thing to the array, and you're back to square one:
var rja = Promise.reject(new Error()); var rjb = Promise.reject(new Error()); rja .return([ rja, rjb ]) .spread(console.log) .catch(console.error);
Gives an "Unhandled rejection Error" as well.
The text was updated successfully, but these errors were encountered:
Hm, the error of rjb is nowhere handled?
rjb
Sorry, something went wrong.
Yes it is. Try doing this:
var rja = Promise.resolve(); var rjb = Promise.reject(new Error()); rja .return([ rja, rjb ]) .spread(console.log) .catch(console.error);
Whether using an array or Promise.join it is handled.
Promise.join
a89a84f
👍 I updated Bluebird, ran the tests and poof, all "unhandled" errors were gone :)
Port fixes to #721, #738, #733
f546f73
No branches or pull requests
Gives an "Unhandled rejection Error" with Bluebird 2.9.34.
The example seems freakish, but it is a distilled version of a more complex scenario where the join has more arguments.
My first thought was to swap a simple array for the join, but add another thing to the array, and you're back to square one:
Gives an "Unhandled rejection Error" as well.
The text was updated successfully, but these errors were encountered: