Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

None of the links for CDN hosted builds seem to work #757

Closed
tjconcept opened this issue Sep 9, 2015 · 7 comments
Closed

None of the links for CDN hosted builds seem to work #757

tjconcept opened this issue Sep 9, 2015 · 7 comments

Comments

@tjconcept
Copy link

@tjconcept tjconcept commented Sep 9, 2015

@jimaek
Copy link

@jimaek jimaek commented Sep 9, 2015

It looks like jsDelivr never hosted this file.
http://www.jsdelivr.com/#!bluebird

@petkaantonov
Copy link
Owner

@petkaantonov petkaantonov commented Sep 9, 2015

the github release does come with those files so it's a bug with jsdelivr?

@jimaek
Copy link

@jimaek jimaek commented Sep 9, 2015

Its not a bug. If you need these files then you need to specify them here https://github.com/jsdelivr/jsdelivr/blob/master/files/bluebird/update.json for the bot to pick them up.

@petkaantonov
Copy link
Owner

@petkaantonov petkaantonov commented Sep 9, 2015

oh I recalled that I had specified a wildcard for the browser folder.. so a PR is needed there

@mikeyhew
Copy link

@mikeyhew mikeyhew commented Dec 17, 2015

It's been just over 3 months since this was posted, and the links for bluebird.core are still missing from jsdelivr. Just thought I'd bring it up again in case it was forgotten.

benjamingr added a commit that referenced this issue Dec 30, 2015
This works just fine in 3.x bluebirdjs.com , need to remove links that no longer exist for .core.js
@benjamingr
Copy link
Collaborator

@benjamingr benjamingr commented Dec 30, 2015

Wait no, that's not it. Looking into this - the build doesn't produce those files anymore at all.

@petkaantonov
Copy link
Owner

@petkaantonov petkaantonov commented Feb 12, 2016

This is fixed for 3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.