-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New warnings should indicate origin #861
Comments
There should be a long stack trace as this warning is not even enabled if long stack traces are not enabled |
Long stack traces are enable but I go the error above anyway. My bluebird configuration: Promise.config({
warnings: true,
longStackTraces: true,
}); |
This code can reproduce the error: var Promise = require('bluebird');
Promise.config({
warnings: true,
longStackTraces: true,
});
Promise.resolve()
.then(function () {
Promise.resolve();
})
; This warning show up:
Ps: I'am currently using the |
Thanks, I'll look into it |
This was actually bug with Promise.resolve rather than the warning system |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The new warnings introduces by bluebird 3 are quite handy to avoid bugs, but the error they refer to can be quite hard to pinpoint in large codebases:
In my case this was due to the use of old-style callbacks that didn't return anything, but maybe Bluebird could somewhat use the longStackTrace mechanism to indicate the origin of the error to facilitate debugging.
The text was updated successfully, but these errors were encountered: