New warnings should indicate origin #861

Activity

1. petkaantonov commented on Nov 9, 2015

   

   petkaantonov

   on Nov 9, 2015

   Owner

   More actions

   There should be a long stack trace as this warning is not even enabled if long stack traces are not enabled
2. floross commented on Nov 10, 2015

   

   floross

   on Nov 10, 2015

   Author

   More actions

   Long stack traces are enable but I go the error above anyway.

   My bluebird configuration:

   Promise.config({
       warnings: true,
       longStackTraces: true,
   });
3. floross commented on Nov 10, 2015

   

   floross

   on Nov 10, 2015

   Author

   More actions

   This code can reproduce the error:

   var Promise = require('bluebird');
   
   Promise.config({
       warnings: true,
       longStackTraces: true,
   });
   
   Promise.resolve()
       .then(function () {
           Promise.resolve();
       })
   ;

   This warning show up:

   Warning: a promise was created in a  handler but was not returned from it
       at processImmediate [as _immediateCallback] (timers.js:367:17)
   
   

   Ps: I'am currently using the 3.0.5 version of bluebird
4. petkaantonov commented on Nov 10, 2015

   

   petkaantonov

   on Nov 10, 2015

   Owner

   More actions

   Thanks, I'll look into it
5. petkaantonov

   added

   bug

   3.0.0

   on Nov 10, 2015
6. petkaantonov

   closed this as completedin 163d388on Dec 1, 2015
7. petkaantonov

   added a commit that references this issue on Dec 1, 2015

   Fixes #861

   This issue will close once commit 23d3516 is merged into the 'master' branch.

   23d3516
8. petkaantonov commented on Dec 1, 2015

   

   petkaantonov

   on Dec 1, 2015

   Owner

   More actions

   This was actually bug with Promise.resolve rather than the warning system