New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for increased granularity in warning control #920

Closed
nazrhyn opened this Issue Dec 16, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@nazrhyn

nazrhyn commented Dec 16, 2015

Following on from my my comments in petkaantonov/bluebird#903, could we extend the capabilities of Promise.config to accept, in addition to this...

Promise.config({
    warnings: true|false
});

...perhaps something like this...

Promise.config({
    warnings: {
        typeone: true|false,
        typetwo: true|false,
        typethree: true|false
    }
});
// I'll leave the names up to you, if you decide to do this.

I would like to leave Warning: .then() only accepts functions and Warning: a promise was rejected with a non-error turned on, but will generally need to have Warning: a promise was created in a handler but none were returned from it turned off as it happens too frequently (due to external issues).

@nazrhyn

This comment has been minimized.

Show comment
Hide comment
@nazrhyn

nazrhyn Dec 16, 2015

Awesome! 👍

nazrhyn commented Dec 16, 2015

Awesome! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment