Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using .timeout(), I get a warning that says "cancellation is disabled" #970

Closed
JoshuaWise opened this issue Jan 22, 2016 · 2 comments
Closed

Comments

@JoshuaWise
Copy link

In my code, I'm not using .cancel() at all.

From my understanding, .timeout() rejects a promise, not cancels it. But the whenever my timeout fires, I get a warning that says "cancellation is disabled". It appears that the timeout promise was rejected as expected.

Is there any difference with using .timeout() with cancellation disabled vs enabled? Why am I getting this warning?

@mrnerdhair
Copy link

See issue #891; it is indeed supposed to cancel the promise, if cancellation is enabled. The docs do omit this point, though.

@JoshuaWise
Copy link
Author

I see, thanks for the info.
And thanks for the quick fix, petkaantonov..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants