-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exception on Bluebird 3.1.2 and node 0.12.2 #978
Comments
Sigh. I had a feeling it was too good to be true that there was a solution to modify .length |
Node 0.12 has generators? I didn't even remember that, is that with a flag or without it? Anyway, this concerns me since having programs behave differently in two different versions of node is probably a bad idea. |
with --harmony |
@petkaantonov to be fair, it's supposed to be configurable http://www.ecma-international.org/ecma-262/6.0/index.html#sec-functioninitialize so 0.12 is just using an old buggy version of v8 here - we can put a caveat for Node users with |
I am fine with just adding a warning. 0.12 is indeed really old. |
@benjamingr still breaking code is not worth it here at all, it's just a pointless "nice to have" thing. |
Thanks for the notice. |
Hi,
I am getting this exception after upgrading to Bluebird 3.1.2:
TypeError: Cannot redefine property: length
at defineProperty (native)
at Function.Promise.coroutine (/home/ubuntu/services/sender/source/node_modules/bluebird/js/release/generators.js:188:5)
Looks like something that was added in 6bd757e
Notice that I am using node 0.12.2, maybe length cannot be overridden there ?
The text was updated successfully, but these errors were encountered: