Replaced Promise.each with Promise.mapSeries #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The serial version of map() isn’t each(), it’s mapSeries() – i.e., if you want to replace a piece of code that doesn’t fail when certain promises in an array fail but you want to maintain the order of promise execution, you should use mapSeries().
e.g.,
```
Promise.map(inspections, ((inspection) -> return inspection().reflect()), {concurrency: 1})
.then (inspection) ->
console.log "\nResults:\n"
inspection
.each (inspection) ->
if inspection.isFulfilled()
console.log " ✅ #{inspection.value()}"
else
console.log " ❌ #{inspection.reason().message}"
```
In the above code, replace .map() with .mapSeries() and you will get the desired effect. Replace it with .each(), as previously suggested and you won’t.
Also removed the broken sentence "This makes sense because the order of the even with the `{concurrency: 1}`." as it doesn’t make grammatical sense and I’m not sure it adds anything to understanding the problem and find the alternative sooner.
|
Thanks, Petka :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The serial version of
.map()isn’t.each(), it’s.mapSeries()– i.e., if you want to replace a piece of code that doesn’t fail when certain promises in an array fail but you want to maintain the order of promise execution, you should use.mapSeries().e.g.,
In the above code, replace .map() with .mapSeries() and you will get the desired effect. Replace it with .each(), as previously suggested and you won’t.
Also removed the broken sentence "This makes sense because the order of the even with the
{concurrency: 1}." as it doesn’t make grammatical sense and I’m not sure it adds anything to understanding the problem and find the alternative sooner.