New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #1314: yielding a function should not call the function #1315

Merged
merged 2 commits into from Jan 27, 2017

Conversation

Projects
None yet
3 participants
@giltayar
Contributor

giltayar commented Jan 4, 2017

When rejecting a non-promise value, string.replace is used, and the value is passed as second parameter. But string.replace, if the second parameter is a function, will call that function.
This commit fixes this by using value.toString().

Gil Tayar
Fixed #1314: yielding a function should not call the function
   When rejecting a non-promise value, string.replace is used,
    and the value is passed as second parameter.
    But string.replace, if the second value is a function, will
    call that function.
    This commit fixes this by using value.toString().
@benjamingr

This comment has been minimized.

Show comment
Hide comment
@benjamingr

benjamingr Jan 5, 2017

Collaborator

LGTM, @petkaantonov ?

Collaborator

benjamingr commented Jan 5, 2017

LGTM, @petkaantonov ?

@giltayar

This comment has been minimized.

Show comment
Hide comment
@giltayar
Contributor

giltayar commented Jan 6, 2017

@benjamingr benjamingr merged commit 0566325 into petkaantonov:master Jan 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@benjamingr

This comment has been minimized.

Show comment
Hide comment
@benjamingr

benjamingr Jan 27, 2017

Collaborator

Thanks!

Collaborator

benjamingr commented Jan 27, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment