Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Promise.reduce unhandled rejections (#1501) #1502

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Feb 8, 2018

Quick and dirty fix for #1501.

I doubt this is the best way to do it, but it works.

I am not sure the value of promise is correct in this line:

maybePromise = values[j] = tryConvertToPromise(values[j], promise);

petkaantonov added a commit that referenced this issue May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants