Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ES6 import strategy #1594

Merged
merged 2 commits into from May 24, 2019

Conversation

Projects
None yet
4 participants
@Richienb
Copy link
Contributor

commented May 4, 2019

Using the old import strategy, the following error is produced:

Uncaught TypeError: Promise is not a constructor

It's been fixed in this PR.

@benjamingr

This comment has been minimized.

Copy link
Collaborator

commented May 4, 2019

There's something wrong with your build - the way you fixed it too shouldn't technically work because the export is Promise and there is no named export (which is not destructuring)

@Richienb

This comment has been minimized.

Copy link
Contributor Author

commented May 4, 2019

@benjamingr That's strange. Anyways, here's a link to the repo that had this problem.

@Gp2mv3

This comment has been minimized.

Copy link

commented May 9, 2019

We had the exact same issue in a React Native app

@Richienb

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

@benjamingr It seems as if the import can spontaneously stop and start working. As a result, we can just add the replacement to the docs instead of replacing the current code.

@petkaantonov petkaantonov merged commit 3cf64ce into petkaantonov:master May 24, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@Richienb Richienb deleted the Richienb:patch-1 branch May 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.