GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
currently, due to sharing of the promise, the caller that does the
resolve/reject passes its domain to other callbacks causing unexpected
should preserve domain of the callback function
Hehe, Function#bind in bluebird. How would this work with bluebird's .bind for context preservation?
test promise#bind to keep this reference
It seems process.bind is smart enough to keep Function#bind reference bound.
I have added tests for that.
Can you remove the implementation from the PR and just leave the tests?
A full fix will have to remove all the domain code from async.js and also it needs to be implemented more efficiently.
sure, let me edit it out.
removed fix, left failing tests (updated)
letting bluebird team implement optimized solution
Bind callbacks to domains at proper point