should preserve domain of the callback function #664
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently, due to sharing of the promise, the caller that does the resolve/reject passes its domain to other callbacks causing unexpected behavior.
|
Hehe, |
|
It seems process.bind is smart enough to keep Function#bind reference bound. |
|
Can you remove the implementation from the PR and just leave the tests? A full fix will have to remove all the domain code from async.js and also it needs to be implemented more efficiently. |
|
sure, let me edit it out. |
letting bluebird team implement optimized solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, due to sharing of the promise, the caller that does the
resolve/reject passes its domain to other callbacks causing unexpected
behavior.