New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promise.coroutine should respect the arity of the generator #933
Conversation
use es5 defineProperty
What's the behavior of this on old IE? |
on IE arity will be 0 |
@renegare why the mocha test changes? Also, can you please add some tests to this? |
@benjamingr looks like a test has already been added. Are there any browser obstacles to merging this? |
@ALL happy new year and all that jazz ... been awol but back. @benjamingr ... old IE ... do they even support generators? @benjamingr ... could you suggest a better place to put tests? i presummed @spion I have not taken a look, I'm on osx. Is this a manual process to verify in IE (and all other browsers) or is there a more simpler way to do so? Apologies on the slowness of getting back. If you can give me clearer direction or someone would like take this over, feel free :) |
Only through regenerator and similar tools. I was just concerned this would not break things there. Testing it - it looks fine.
I would add two/three tests for different scenarios (function with lots of arguments, function without arguments, etc). Happy new year. |
Cool fair enough, I'll update the tests and run through some manual tests and report back. as for regenerator, do you have a link to this? sounds interesting ... I've only recently come to appreciate gens #noO0b |
found it: https://github.com/facebook/regenerator is it me or do we refuse to let old IEs die ...? |
@renegare we build things so people use them - if people still use older versions of IE, we have nothing to do about it except support if unless we're willing to lose money. |
@benjamingr I'm not being paid to do this ...;) but hey its just a thought ... ... the next es7,8,9 more polyfills to keep old IEs on board ... ... then again you may be right about money. It does keep me in a job. |
Merged in 3.1.2 |
Thanks guys. |
#927