Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise.coroutine should respect the arity of the generator #933

Closed

Conversation

renegare
Copy link

@benjamingr
Copy link
Collaborator

What's the behavior of this on old IE?

@petkaantonov
Copy link
Owner

on IE arity will be 0

@benjamingr
Copy link
Collaborator

@renegare why the mocha test changes? Also, can you please add some tests to this?

@spion
Copy link
Collaborator

spion commented Jan 6, 2016

@benjamingr looks like a test has already been added. Are there any browser obstacles to merging this?

@renegare
Copy link
Author

renegare commented Jan 7, 2016

@ALL happy new year and all that jazz ... been awol but back.

@benjamingr ... old IE ... do they even support generators?

@benjamingr ... could you suggest a better place to put tests? i presummed test/mocha/generator.js is for testing the usage of generators. no?

@spion I have not taken a look, I'm on osx. Is this a manual process to verify in IE (and all other browsers) or is there a more simpler way to do so?

Apologies on the slowness of getting back. If you can give me clearer direction or someone would like take this over, feel free :)

@benjamingr
Copy link
Collaborator

old IE ... do they even support generators?

Only through regenerator and similar tools. I was just concerned this would not break things there. Testing it - it looks fine.

.. could you suggest a better place to put tests? i presummed test/mocha/generator.js is for testing the usage of generators. no?

I would add two/three tests for different scenarios (function with lots of arguments, function without arguments, etc).

Happy new year.

@renegare
Copy link
Author

renegare commented Jan 7, 2016

Cool fair enough, I'll update the tests and run through some manual tests and report back.

as for regenerator, do you have a link to this? sounds interesting ... I've only recently come to appreciate gens #noO0b

@renegare
Copy link
Author

renegare commented Jan 7, 2016

found it: https://github.com/facebook/regenerator

is it me or do we refuse to let old IEs die ...?

@benjamingr
Copy link
Collaborator

@renegare we build things so people use them - if people still use older versions of IE, we have nothing to do about it except support if unless we're willing to lose money.

@renegare
Copy link
Author

renegare commented Jan 7, 2016

@benjamingr I'm not being paid to do this ...;) but hey its just a thought ...

... the next es7,8,9 more polyfills to keep old IEs on board ...

... then again you may be right about money. It does keep me in a job.

@petkaantonov
Copy link
Owner

Merged in 3.1.2

@renegare renegare deleted the promise-coroutine-arity branch January 24, 2016 21:37
@renegare
Copy link
Author

Thanks guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants