Promise.coroutine should respect the arity of the generator

[renegare]

#927

[benjamingr]

What's the behavior of this on old IE?

[benjamingr]

What's the behavior of this on old IE?

[petkaantonov]

on IE arity will be 0

[petkaantonov]

on IE arity will be 0

[benjamingr]

@renegare why the mocha test changes? Also, can you please add some tests to this?

[benjamingr]

@renegare why the mocha test changes? Also, can you please add some tests to this?

[spion]

@benjamingr looks like a test has already been added. Are there any browser obstacles to merging this?

[spion]

@benjamingr looks like a test has already been added. Are there any browser obstacles to merging this?

[renegare]

@ALL happy new year and all that jazz ... been awol but back.

@benjamingr ... old IE ... do they even support generators?

@benjamingr ... could you suggest a better place to put tests? i presummed test/mocha/generator.js is for testing the usage of generators. no?

@spion I have not taken a look, I'm on osx. Is this a manual process to verify in IE (and all other browsers) or is there a more simpler way to do so?

Apologies on the slowness of getting back. If you can give me clearer direction or someone would like take this over, feel free :)

[renegare]

@ALL happy new year and all that jazz ... been awol but back.

@benjamingr ... old IE ... do they even support generators?

@benjamingr ... could you suggest a better place to put tests? i presummed test/mocha/generator.js is for testing the usage of generators. no?

@spion I have not taken a look, I'm on osx. Is this a manual process to verify in IE (and all other browsers) or is there a more simpler way to do so?

Apologies on the slowness of getting back. If you can give me clearer direction or someone would like take this over, feel free :)

[benjamingr]

old IE ... do they even support generators?

Only through regenerator and similar tools. I was just concerned this would not break things there. Testing it - it looks fine.

.. could you suggest a better place to put tests? i presummed test/mocha/generator.js is for testing the usage of generators. no?

I would add two/three tests for different scenarios (function with lots of arguments, function without arguments, etc).

Happy new year.

[benjamingr]

old IE ... do they even support generators?

Only through regenerator and similar tools. I was just concerned this would not break things there. Testing it - it looks fine.

.. could you suggest a better place to put tests? i presummed test/mocha/generator.js is for testing the usage of generators. no?

I would add two/three tests for different scenarios (function with lots of arguments, function without arguments, etc).

Happy new year.

[renegare]

Cool fair enough, I'll update the tests and run through some manual tests and report back.

as for regenerator, do you have a link to this? sounds interesting ... I've only recently come to appreciate gens #noO0b

[renegare]

Cool fair enough, I'll update the tests and run through some manual tests and report back.

as for regenerator, do you have a link to this? sounds interesting ... I've only recently come to appreciate gens #noO0b

[renegare]

found it: https://github.com/facebook/regenerator

is it me or do we refuse to let old IEs die ...?

[renegare]

found it: https://github.com/facebook/regenerator

is it me or do we refuse to let old IEs die ...?

[benjamingr]

@renegare we build things so people use them - if people still use older versions of IE, we have nothing to do about it except support if unless we're willing to lose money.

[benjamingr]

@renegare we build things so people use them - if people still use older versions of IE, we have nothing to do about it except support if unless we're willing to lose money.

[renegare]

@benjamingr I'm not being paid to do this ...;) but hey its just a thought ...

... the next es7,8,9 more polyfills to keep old IEs on board ...

... then again you may be right about money. It does keep me in a job.

[renegare]

@benjamingr I'm not being paid to do this ...;) but hey its just a thought ...

... the next es7,8,9 more polyfills to keep old IEs on board ...

... then again you may be right about money. It does keep me in a job.

[petkaantonov]

Merged in 3.1.2

[petkaantonov]

Merged in 3.1.2

[renegare]

Thanks guys.

[renegare]

Thanks guys.