New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow validation on optional fields #399

Closed
dusktreader opened this Issue Nov 30, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@dusktreader
Contributor

dusktreader commented Nov 30, 2016

I have some optional fields in my table. I also have some validation constraints that I would like to apply to them if they are defined. Currently, if a field is not defined but a constraint is applied, the following exception is produced:
petl.errors.FieldSelectionError: selection is not a field or valid field index: 'digital_runtime'

I would like to be able to apply validation to a field if it exists and ignore the validation constraint if it does not

@alimanfoo

This comment has been minimized.

Collaborator

alimanfoo commented Nov 30, 2016

@dusktreader

This comment has been minimized.

Contributor

dusktreader commented Dec 1, 2016

I'm working on one presently. It's a fairly small change, but I'm making sure to include a couple of unit tests as well

@dusktreader

This comment has been minimized.

Contributor

dusktreader commented Dec 21, 2016

@alimanfoo i think this issue can be closed now that the pr is merged

@alimanfoo

This comment has been minimized.

Collaborator

alimanfoo commented Dec 21, 2016

Thanks

@alimanfoo alimanfoo closed this Dec 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment