New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make XLSXView close the workbook after iterating #387

Merged
merged 2 commits into from Sep 21, 2016

Conversation

Projects
None yet
2 participants
@mattkatz
Contributor

mattkatz commented Sep 8, 2016

openpyxl doesn't explicitly close the workbook after you are done iterating it.
This means that if you use petl and then try to rename or move the workbook you get a PermissionError
There's an issue to expose a workbook.close property directly but this will work until then.
https://bitbucket.org/openpyxl/openpyxl/issues/673/close-file-when-done

mattkatz and others added some commits Sep 8, 2016

make XLSXView close the workbook after iterating
openpyxl doesn't explicitly close the workbook after you are done iterating it.
This means that if you use petl and then try to rename or move the workbook you get a PermissionError
There's an issue to expose a workbook.close property directly but this will work until then.
https://bitbucket.org/openpyxl/openpyxl/issues/673/close-file-when-done
mkatz
@mattkatz

This comment has been minimized.

Contributor

mattkatz commented Sep 8, 2016

Not sure why the build failed. pypy builds on my branch in travis ci. I deleted an old vim file and it should work now.

@mattkatz

This comment has been minimized.

Contributor

mattkatz commented Sep 21, 2016

@alimanfoo I'm kind of baffled why those tests would start failing on just the pypy section. The code I'm adding doesn't touch it at all and if you check here all the tests pass: https://travis-ci.org/mattkatz/petl

Happy to help if you can give me a pointer on this.

@alimanfoo

This comment has been minimized.

Collaborator

alimanfoo commented Sep 21, 2016

Hi @mattkatz, something must have changed in pypy. The travis tests on this PR run under pypy 5.3.1, whereas your travis tests ran with pypy 2.5.0. I'm happy to merge this PR and deal with the pypy issue separately.

@alimanfoo alimanfoo merged commit 2004371 into petl-developers:master Sep 21, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@alimanfoo alimanfoo added this to the v1.2 milestone Sep 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment