New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #393: update toxlsx and XLSXView for openpyxl 2.4.0 compatibility #394

Merged
merged 2 commits into from Oct 21, 2016

Conversation

Projects
None yet
2 participants
@henryrizzi
Contributor

henryrizzi commented Oct 20, 2016

This addresses issue #393 by changing the way in which xlsx imports and exports occur.

henryrizzi added some commits Oct 20, 2016

@henryrizzi

This comment has been minimized.

Contributor

henryrizzi commented Oct 20, 2016

I removed encoding from petl/io/xlsx toxlsx, as this is no longer a supported argument in the most recent version of openpyxl. It seems like it always just sets that to 'utf-8' in the most recent version. :/

@henryrizzi henryrizzi changed the title from update toxlsx and XLSXView for 2.4.0 compatibility to Resolves #393: update toxlsx and XLSXView for openpyxl 2.4.0 compatibility Oct 20, 2016

@alimanfoo alimanfoo merged commit b6da666 into petl-developers:master Oct 21, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alimanfoo

This comment has been minimized.

Collaborator

alimanfoo commented Oct 21, 2016

Thank you!

@alimanfoo

This comment has been minimized.

Collaborator

alimanfoo commented Oct 25, 2016

Thanks a lot Henry, I'll review ASAP.

On Thursday, 20 October 2016, Henry Rizzi notifications@github.com wrote:

I removed encoding from petl/io/xlsx toxlsx, as this is no longer a
supported argument in the most recent version of openpyxl. It seems like it
always just sets that to 'utf-8' in the most recent version. :/


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#394 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAq8Qmmfu8RJhN9Nol7CfATY5xZrHLhEks5q18OTgaJpZM4KcZev
.

Alistair Miles
Head of Epidemiological Informatics
Centre for Genomics and Global Health http://cggh.org
The Wellcome Trust Centre for Human Genetics
Roosevelt Drive
Oxford
OX3 7BN
United Kingdom
Email: alimanfoo@googlemail.com
Web: http://purl.org/net/aliman
Twitter: https://twitter.com/alimanfoo
Tel: +44 (0)1865 287721

@alimanfoo alimanfoo added this to the v1.2 milestone Dec 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment