Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing along **kwargs to xlrd and encoding to openpyxl (issue 469) #470

Closed
wants to merge 0 commits into from

Conversation

@gjunqueira
Copy link

commented May 28, 2019

Pull request for issue #469 and also to fix 'encoding' that was not passed along to toxlsx.

I don't know how to provide the itens below, but I guess the pull request is simple enough to pass the approval. :) [first time contributing with code to a open source project]

  • Includes unit tests
  • New functions have docstrings with examples that can be run with doctest
  • New functions are included in API docs
  • Docstrings include notes for any changes to API or behaviour
  • Travis CI passes (unit tests run under Linux)
  • AppVeyor CI passes (unit tests run under Windows)
  • Unit test coverage has not decreased (see Coveralls)
  • All changes documented in docs/changes.rst
@coveralls

This comment has been minimized.

Copy link

commented May 28, 2019

Coverage Status

Coverage decreased (-15.5%) to 75.692% when pulling a26625e on gjunqueira:master into 1d33ca0 on petl-developers:master.

@alimanfoo alimanfoo closed this Aug 6, 2019

@alimanfoo alimanfoo force-pushed the gjunqueira:master branch from a26625e to 5851ca5 Aug 6, 2019

@alimanfoo

This comment has been minimized.

Copy link
Collaborator

commented Aug 6, 2019

Apologies this got dropped. Closing in favour of #473 where there is some additional work to deal with the fact that openpyxl does not seem to support the encoding argument at all.

@alimanfoo

This comment has been minimized.

Copy link
Collaborator

commented Aug 6, 2019

Also hopefully the slow response from me does not put you off contributing to other open source projects in future :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.