Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new parameter parser in fromxml() for custom parsers #527

Merged
merged 7 commits into from
Oct 5, 2020
Merged

Added new parameter parser in fromxml() for custom parsers #527

merged 7 commits into from
Oct 5, 2020

Conversation

juarezr
Copy link
Member

@juarezr juarezr commented Oct 5, 2020 •
edited
Loading

This PR has the objective of restricting use of includes in fromxml().

Changes

  1. Added new parameter parser for fromxml() for custom parsers.
  2. Disabled file includes by default in fromxml()
  3. Added tests for file inclusion on fromxml()
  4. Improved the docs about fromxml() new parameter.

Checklist

Checklist for for pull requests including new code and/or changes to existing code...

  • Code
    • Includes unit tests
    • New functions have docstrings with examples that can be run with doctest
    • New functions are included in API docs
    • Docstrings include notes for any changes to API or behaviour
    • All changes documented in docs/changes.rst
  • Testing
    • (Optional) Tested local against remote servers
    • Travis CI passes (unit tests run under Linux)
    • AppVeyor CI passes (unit tests run under Windows)
    • Unit test coverage has not decreased (see Coveralls)
  • Changes
    • Ready to review
    • Ready to merge

@juarezr juarezr added Bug It must work in all situations, but this failed Maintainability Issues for code modernization, improve development, testing labels Oct 5, 2020
@juarezr juarezr requested a review from alimanfoo October 5, 2020 22:52
@coveralls
Copy link

coveralls commented Oct 5, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.08%) to 91.905% when pulling b2fd30b on juarezr:custom-xml-parser into bed3bfb on petl-developers:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.4%) to 90.63% when pulling 11778b2 on juarezr:custom-xml-parser into bed3bfb on petl-developers:master.

@juarezr juarezr merged commit 52447c0 into petl-developers:master Oct 5, 2020
@juarezr juarezr deleted the custom-xml-parser branch October 5, 2020 23:55
@juarezr
Copy link
Member Author

juarezr commented Nov 27, 2020 •
edited
Loading

This PR was released in v1.68.0 also fixes the CVE-2020-29128.

@juarezr juarezr mentioned this pull request Nov 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimanfoo alimanfoo Awaiting requested review from alimanfoo

Assignees
No one assigned
Labels
Bug It must work in all situations, but this failed Maintainability Issues for code modernization, improve development, testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juarezr @coveralls