Petr Janda petrjanda

Organizations

@ngneers
petrjanda commented on pull request petrjanda/coreos-ec2#4
@petrjanda

Thinking it might be better to move camilization to the cluster_conf. I think snake case is more pythonic and we need camel case just before we sen…

petrjanda commented on pull request petrjanda/coreos-ec2#4
@petrjanda

Might be good to run some validations here in the future. In general boto3 provides nice errors so I didn't invest here too much, but we might veri…

petrjanda opened pull request petrjanda/coreos-ec2#4
@petrjanda
Generic volume config
1 commit with 45 additions and 18 deletions
@petrjanda
  • @petrjanda 4e3fa5c
    closed #3 better volume config
@petrjanda
petrjanda commented on issue petrjanda/coreos-ec2#3
@petrjanda

Right, I was revising thinking that way as well. There is a cool trick we can do I believe.

petrjanda commented on issue petrjanda/coreos-ec2#3
@petrjanda

Makes sense, would we just provide defaults in the code and override it by the configuration spec? Sort of recursive merge of default and config?

@petrjanda
@petrjanda
@petrjanda
@petrjanda
@petrjanda
@petrjanda
@petrjanda
  • @petrjanda 22dcd86
    format device only if not formatted
@petrjanda
  • @petrjanda 138badd
    fix volume mounting after the cluster stop/start
@petrjanda
@petrjanda
  • @petrjanda 2b899a5
    better security groups handling
@petrjanda
@petrjanda
@petrjanda
  • @petrjanda 98fed9c
    use cluster name from args
@petrjanda
@petrjanda
  • @petrjanda d79b00c
    assert actual correct call
@petrjanda
  • @petrjanda a40af25
    check the core os discovery fetcher
@petrjanda
  • @petrjanda 971ec38
    mock call to etcd discovery
@petrjanda
  • @petrjanda 5814d15
    add tests for conf, refactor more pythonic way to do dict