New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not raise Exception on wait() after terminate or previous wait() #211

Merged
merged 3 commits into from May 20, 2015

Conversation

Projects
None yet
2 participants
@jquast
Member

jquast commented Apr 26, 2015

This matches the same branch of ptyprocess, pexpect/ptyprocess#18 from @reynir, noexception-on-wait-after-terminate, which allows calling the wait() method multiple times without raising an exception.

There is no logical change, only a docstring and adjustments to (otherwise failing) test cases.

(@takluyver: Note that TeamCity comprehends "pairing branch names" across these two repositories and tests them accordingly, but Travis-CI does not (so the test will fail, here). Created issue #210 to address.

Furthermore, described in 4bd7305 it is now necessary to specify >=0.5 requirement of ptyprocess. In this particular case, It isn't terribly harmful, but it is good to start. This too will break the travis-ci build, which would be resolved by release of ptyprocess 0.5 or issue #210)

jquast added some commits Apr 26, 2015

Tests cases and documentation to supplement wait()
This matches the same branch of ptyprocess,
noexception-on-wait-after-terminate, which allows
calling the wait() method multiple times without
raising an exception.
We must specify lower-bound for ptyprocess
Problem:

- user installs pexpect==3.2 and ptyprocess==0.4
- change is made to ptyprocess, 0.5 is available
- change is made to pexpect, 4.0 is available
- user wishes to upgrade, issues "pip install --upgrade pexpect"
- the current version of ptyprocess (0.4) remains installed.

Solution:

- Specify lowerbound '>=0.5' to ensure that existing pexpect
  installations receive new version of ptyprocess.
@takluyver

This comment has been minimized.

Member

takluyver commented Apr 26, 2015

This looks reasonable. We need to actually get round to releasing ptyprocess.

@jquast

This comment has been minimized.

Member

jquast commented Apr 26, 2015

Do we have to wait until ptyprocess is released to merge?

@jquast jquast referenced this pull request Apr 26, 2015

Closed

Teamcity tests ptyprocess #212

@takluyver

This comment has been minimized.

Member

takluyver commented Apr 26, 2015

I'd prefer to keep pexpect master building against released versions of Ptyprocess. As mentioned on #210, it's sort of deliberately inflicted pain to try to ensure a clean distinction between the two packages. I don't think a ptyprocess release is far off, though - we really just need to work out pexpect/ptyprocess#12 and make a decision on pexpect/ptyprocess#10, as far as I know.

@jquast

This comment has been minimized.

Member

jquast commented Apr 27, 2015

That's fine. I'm working out pexpect/ptyprocess#12 now.

Bumping into a strange issue with a new test case I introduced where getecho() returns False on FreeBSD and receiving echo of input in read() calls, even though PtyProcess([cmd], echo=True) is used.

I'm working it out with TeamCity to run some tests across the board for me, I hope to address it soon.

@takluyver

This comment has been minimized.

Member

takluyver commented May 20, 2015

I reran Travis now that Ptyprocess 0.5 is released, and it is now happy with this.

takluyver added a commit that referenced this pull request May 20, 2015

Merge pull request #211 from pexpect/noexception-on-wait-after-terminate
Do not raise Exception on wait() after terminate or previous wait()

@takluyver takluyver merged commit 57a5519 into master May 20, 2015

1 of 3 checks passed

ci/teamcity Finished TeamCity Build Pexpect :: Full Build : Snapshot dependencies failed to start: 3, failed: Pexpect :: MacOs
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@takluyver takluyver deleted the noexception-on-wait-after-terminate branch May 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment