New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExceptionPexpect.__init__: invoke super's init #34

Merged
merged 2 commits into from Jan 7, 2014

Conversation

Projects
None yet
2 participants
@offby1
Contributor

offby1 commented Jan 7, 2014

This avoids an exception in the following:

    import pexpect
    import pickle
    pickle.loads(pickle.dumps(pexpect.EOF('hey you')))
Eric Hanchrow
ExceptionPexpect.__init__: invoke super's init
This avoids an exception in the following:

        import pexpect
        import pickle
        pickle.loads(pickle.dumps(pexpect.EOF('hey you')))
@takluyver

This comment has been minimized.

Member

takluyver commented Jan 7, 2014

This looks sensible. Do you want to add a test for pickling and unpickling an exception object?

Eric Hanchrow
@offby1

This comment has been minimized.

Contributor

offby1 commented Jan 7, 2014

Updated.

takluyver added a commit that referenced this pull request Jan 7, 2014

Merge pull request #34 from offby1/master
ExceptionPexpect.__init__: invoke super's init

@takluyver takluyver merged commit 0b99c3a into pexpect:master Jan 7, 2014

1 check passed

default The Travis CI build passed
Details
@takluyver

This comment has been minimized.

Member

takluyver commented Jan 7, 2014

Thanks, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment