New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix popen_spawn when specifying a path on Windows which contains "\" … #446

Merged
merged 2 commits into from Sep 16, 2017

Conversation

Projects
None yet
3 participants
@eli-b
Contributor

eli-b commented Sep 15, 2017

…separators

@techalchemy

This comment has been minimized.

techalchemy commented Sep 16, 2017

As I mentioned on the referenced PR, it might be a better approach to use posix=(os.name == 'posix') when testing for posix compliance...

@eli-b

This comment has been minimized.

Contributor

eli-b commented Sep 16, 2017

I've updated the PR according to your suggestion.

@takluyver

This comment has been minimized.

Member

takluyver commented Sep 16, 2017

Which referenced PR are you discussing?

@eli-b

This comment has been minimized.

Contributor

eli-b commented Sep 16, 2017

I think @techalchemy meant this PR.

@takluyver takluyver merged commit 1144550 into pexpect:master Sep 16, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 88.76%
Details
@takluyver

This comment has been minimized.

Member

takluyver commented Sep 16, 2017

Thanks, I should have seen that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment