New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset PROMPT_COMMAND in bash for replwrap #459

Merged
merged 2 commits into from Dec 11, 2017

Conversation

Projects
None yet
3 participants
@takluyver
Member

takluyver commented Dec 8, 2017

People may use PROMPT_COMMAND to modify the prompt (hat-tip to @Naereen, who does). Unset it to avoid breaking replwrap.

The line between customisations that people might want to be preserved in replwrap (like aliases) and those that don't make sense (like custom prompts) is somewhat indistinct. But from the uses of PROMPT_COMMAND I've seen, I think it's more likely that it shouldn't apply in replwrap.

@Naereen

This comment has been minimized.

Naereen commented Dec 8, 2017

Great!

@takluyver takluyver merged commit 7cf223c into pexpect:master Dec 11, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 88.748%
Details

@takluyver takluyver deleted the takluyver:unset-prompt-command branch Dec 11, 2017

@Naereen

This comment has been minimized.

Naereen commented Dec 11, 2017

Great!
Do you know when this will be available through pip and in bash_kernel ?

@takluyver

This comment has been minimized.

Member

takluyver commented Dec 11, 2017

When I do a pexpect release ;-). Is it something you'd still like?

@Naereen

This comment has been minimized.

Naereen commented Dec 11, 2017

Well my bug was resolved, but it would be interesting to try it again on my previous PS1/PS2 configuration when possible. (No hurry at all of course!)

@takluyver

This comment has been minimized.

Member

takluyver commented Dec 12, 2017

OK, 4.3.1 is out. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment