New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preexec_fn to PopenSpawn #460

Merged
merged 2 commits into from Dec 21, 2017

Conversation

Projects
None yet
3 participants
@tcwalther
Contributor

tcwalther commented Dec 20, 2017

This PR adds the keyword argument preexec_fn to PopenSpawn, so that it can be passed to the subprocess.Popen call.

@takluyver

This comment has been minimized.

Member

takluyver commented Dec 21, 2017

Makes sense, thanks!

@takluyver takluyver merged commit 28e82cd into pexpect:master Dec 21, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 88.748%
Details
@tcwalther

This comment has been minimized.

Contributor

tcwalther commented Jan 29, 2018

@takluyver Thanks so much for merging. Do you think it would be possible to push a new version 4.3.2 with this functionality to PyPI?

@takluyver

This comment has been minimized.

Member

takluyver commented Jan 29, 2018

I'm trying to get around to reviewing #464 - I'll get a new release out once that's sorted. I'm busy with family matters for the next couple of days, though.

@tcwalther

This comment has been minimized.

Contributor

tcwalther commented Jan 29, 2018

That sounds great, thank you very much!

@ryanpetrello

This comment has been minimized.

Contributor

ryanpetrello commented Feb 8, 2018

@takluyver I'll add my 👍 to the hat on a new PyPI release whenever you have spare time 😄

Thank you very much!

@takluyver

This comment has been minimized.

Member

takluyver commented Feb 10, 2018

OK, pexpect 4.4 is out now. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment