New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed TypeError using readline with spawnu #67
Closed
Closed
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6d7d569
Added test for readline() with spawnu objects.
c1cb2e4
Fixed bug where readline() failed with spawnu objects.
auntieNeo 2859a7f
Moved readline() spawnu test to test_unicode.py.
auntieNeo fb592f2
Added crlf member as suggested in issue #67
auntieNeo 64af3b8
Go away ugly extra line. We don't need you.
auntieNeo File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
#!/usr/bin/env python | ||
# -*- coding: utf-8 -*- | ||
|
||
import pexpect | ||
|
||
ECHO = pexpect.which('echo') | ||
|
||
""" | ||
Test using readline() with spawnu objects. This fails with a TypeError on older | ||
versions of pexpect because bytes are used for line endings rather than | ||
strings. | ||
""" | ||
child = pexpect.spawnu(ECHO, [ "foobar"]) | ||
foobar = child.readline() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you make this a proper test case - i.e. it shouldn't run on import. I'd probably put it in |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, this doesn't work on Python 2, because both alternatives are bytes. And we can't use
u''
literals until we drop Python 3.2 support (soon, but not yet).Actually, we already have a
self.linesep
variable which contains\n
as the appropriate bytes/unicode value. I think we should just makeself.crlf
as a similar class-level variable.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll make these changes later this week and submit another pull request.
2014-06-03 10:50 GMT-06:00 Thomas Kluyver notifications@github.com:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you push to the same branch, this pull request should get updated, so you don't need to open a new one. :-)