Fixes issues when creating MOOIconView from InterfaceBuilder #4

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

felixLam commented Mar 1, 2012

When creating the view from InterfaceBuilder -initWithFrame: is not called. Hence the view is not added as an observer and crashes when trying to remove itself as an observer for the various keypaths.

Owner

peyton commented Mar 1, 2012

Thanks so much! Really appreciate it.

It looks like merges got caught up in this pull request. It's annoying
Github doesn't let you pick a single commit, I know.

Don't worry about fixing the pull request. When I'm next on my laptop,
I'll sort it out.

Sent from my iPhone

On Mar 1, 2012, at 3:10 PM, felixLam
reply@reply.github.com
wrote:

When creating the view from InterfaceBuilder -initWithFrame: is not called. Hence the view is not added as an observer and crashes when trying to remove itself as an observer for the various keypaths.

You can merge this Pull Request by running:

git pull https://github.com/felixLam/MOOMaskedIconView master

Or you can view, comment on it, or merge it online at:

#4

-- Commit Summary --

  • Merge remote-tracking branch 'upstream/master'
  • Fixes issues when creating MOOIconView from InterfaceBuilder

-- File Changes --

M Demo Project/MOOMaskedIconView Demo.xcodeproj/project.pbxproj (4)
M Demo Project/MOOMaskedIconView Demo/AppDelegate.m (7)
M Demo Project/MOOMaskedIconView Demo/ViewController.h (3)
M Demo Project/MOOMaskedIconView Demo/ViewController.m (13)
A MOOMaskedIconView/AHHelper.h (54)
M MOOMaskedIconView/MOOCGImageWrapper.h (8)
M MOOMaskedIconView/MOOCGImageWrapper.m (4)
M MOOMaskedIconView/MOOMaskedIconView.h (171)
M MOOMaskedIconView/MOOMaskedIconView.m (48)
M MOOMaskedIconView/MOOResourceList.h (101)
M MOOMaskedIconView/MOOResourceList.m (96)
M MOOMaskedIconView/MOOStyleTrait.h (34)
M MOOMaskedIconView/MOOStyleTrait.m (1)
M README.md (8)

-- Patch Links --

https://github.com/peyton/MOOMaskedIconView/pull/4.patch
https://github.com/peyton/MOOMaskedIconView/pull/4.diff


Reply to this email directly or view it on GitHub:
#4

Contributor

felixLam commented Mar 1, 2012

Sorry about that. I am still a novice on GitHub. I wasn't sure how to do this correctly. Anyway the commit a06bd4c is the important one.

Very useful classes by the way. Thanks for sharing it.

Owner

peyton commented Mar 1, 2012

It's tricky to get right, and it's even trickier to fix after making a
mistake. Here's a guide for when you have the chance:

https://github.com/peyton/MOOMaskedIconView/wiki/Contributing

Admire the enthusiasm.

Sent from my iPhone

On Mar 1, 2012, at 3:26 PM, felixLam
reply@reply.github.com
wrote:

Sorry about that. I am still a novice on GitHub. I wasn't sure how to do this correctly. Anyway the commit a06bd4c is the important one.

Very useful classes by the way. Thanks for sharing it.


Reply to this email directly or view it on GitHub:
#4 (comment)

@peyton peyton added a commit that referenced this pull request Mar 1, 2012

@peyton peyton Fix issue #4 (IB crashing) cb3f8f8

peyton closed this Mar 1, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment